Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added event agenda component #7

Merged
merged 5 commits into from
May 16, 2024
Merged

added event agenda component #7

merged 5 commits into from
May 16, 2024

Conversation

rayyank10
Copy link
Collaborator

Copy link

aem-code-sync bot commented May 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 13, 2024

Page Scores Audits Google
/event/create/t3 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@qiyundai qiyundai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good already! I've noticed a few small things besides what I've commented on specific lines:

I notice you have more than 1 line breaks after blocks of code in both the JS and CSS files. Could you please run a npm run lint locally and see if there are any issues with the code style according to our linter.

I also notice that the block table has some empty cells. I think we should try to clean it up and keep things laid out as close to the final content as possible. For example, I might try to put the time picker cell on the left and the input label and attr. on the right. I also would merge the unused cells so that I don't need to call checkBoxRow[2].
Screenshot 2024-05-14 at 2 46 51 PM

blocks/event-agenda-component/event-agenda-component.css Outdated Show resolved Hide resolved
blocks/event-agenda-component/event-agenda-component.js Outdated Show resolved Hide resolved
blocks/event-agenda-component/event-agenda-component.js Outdated Show resolved Hide resolved
blocks/event-agenda-component/event-agenda-component.js Outdated Show resolved Hide resolved
@rayyank10 rayyank10 requested a review from qiyundai May 15, 2024 18:42
Copy link
Collaborator

@qiyundai qiyundai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! One more small thing.

const { createTag } = await import(`${getLibs()}/utils/utils.js`);
const miloLibs = getLibs();

await Promise.all([
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move these + the miloLibs = getLibs() into the init call. The convention is that these. I don't think this will break anything but we should try to load the modules with as little side effects as possible.

@qiyundai qiyundai merged commit f993910 into stage May 16, 2024
3 of 4 checks passed
@qiyundai qiyundai deleted the agendaComp branch December 23, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants