-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added event agenda component #7
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good already! I've noticed a few small things besides what I've commented on specific lines:
I notice you have more than 1 line breaks after blocks of code in both the JS and CSS files. Could you please run a npm run lint locally and see if there are any issues with the code style according to our linter.
I also notice that the block table has some empty cells. I think we should try to clean it up and keep things laid out as close to the final content as possible. For example, I might try to put the time picker cell on the left and the input label and attr. on the right. I also would merge the unused cells so that I don't need to call checkBoxRow[2].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! One more small thing.
const { createTag } = await import(`${getLibs()}/utils/utils.js`); | ||
const miloLibs = getLibs(); | ||
|
||
await Promise.all([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move these + the miloLibs = getLibs() into the init call. The convention is that these. I don't think this will break anything but we should try to load the modules with as little side effects as possible.
Added the event agenda component
Resolves: https://jira.corp.adobe.com/browse/MWPW-147083
Test URLs: