Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-161502] User Access Control POC #273

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

[MWPW-161502] User Access Control POC #273

wants to merge 16 commits into from

Conversation

qiyundai
Copy link
Collaborator

@qiyundai qiyundai commented Nov 4, 2024

Describe your specific features or fixes and provide a preview link for the feature being incorporated

Resolves: MWPW-NUMBER

Test URLs:

Copy link

aem-code-sync bot commented Nov 4, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 21.05263% with 45 lines in your changes missing coverage. Please review.

Project coverage is 50.85%. Comparing base (13516fc) to head (fec1395).
Report is 158 commits behind head on dev.

Files with missing lines Patch % Lines
ecc/scripts/profile.js 19.64% 45 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #273       +/-   ##
===========================================
- Coverage   67.22%   50.85%   -16.38%     
===========================================
  Files           2        2               
  Lines         238      293       +55     
===========================================
- Hits          160      149       -11     
- Misses         78      144       +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiyundai qiyundai marked this pull request as ready for review November 4, 2024 21:32
@qiyundai qiyundai added the do not merge Still waiting for something label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Still waiting for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants