Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-157579] Event Title Duplication Prevention #200

Merged
merged 11 commits into from
Sep 5, 2024

Conversation

qiyundai
Copy link
Collaborator

@qiyundai qiyundai commented Aug 31, 2024

Copy link

aem-code-sync bot commented Aug 31, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 31, 2024

Page Scores Audits Google
M / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.36%. Comparing base (13516fc) to head (0385643).
Report is 62 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #200      +/-   ##
==========================================
+ Coverage   67.22%   67.36%   +0.13%     
==========================================
  Files           2        2              
  Lines         238      239       +1     
==========================================
+ Hits          160      161       +1     
  Misses         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -94,7 +94,7 @@ export default function init(el) {
generateToolTip(r);
break;
case 1:
await decorateTextfield(r, { id: 'info-field-event-title' });
await decorateTextfield(r, { id: 'info-field-event-title' }, 'This event title is already taken');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we can get the message from word document? and can it be - "This event title is already taken for a given event series, date and venue combination"

@aem-code-sync aem-code-sync bot temporarily deployed to event-duplication-check August 31, 2024 01:51 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to event-duplication-check September 3, 2024 19:58 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to event-duplication-check September 3, 2024 20:05 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to event-duplication-check September 4, 2024 16:39 Inactive
@qiyundai qiyundai changed the title Event Title Duplication Prevention [MWPW-157579] Event Title Duplication Prevention Sep 4, 2024
@apganapa-adobe
Copy link
Collaborator

looks like there is conflict... after resolving it, this can get merged

@aem-code-sync aem-code-sync bot temporarily deployed to event-duplication-check September 5, 2024 13:55 Inactive
@apganapa-adobe apganapa-adobe merged commit 5284d5c into dev Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants