Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new spectrum component to milo lib #16

Merged
merged 11 commits into from
May 24, 2024
Merged

Adding new spectrum component to milo lib #16

merged 11 commits into from
May 24, 2024

Conversation

gbajaj91
Copy link
Collaborator

@gbajaj91 gbajaj91 commented May 22, 2024

Adding Spectrum Web Component Integration support
Using picker element.

Resolves: MWPW-147728

Test URLs:

Copy link

aem-code-sync bot commented May 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@gbajaj91 gbajaj91 requested a review from qiyundai May 22, 2024 13:11
Copy link

aem-code-sync bot commented May 22, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@@ -26,21 +29,19 @@ async function decorateCloudTagSelect(column) {
// const clouds = await getClouds();

// if (!clouds) return;
// FIXME: use correct data source rather than hardcoded values.
const clouds = ['Creative Cloud', 'DX'];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take stage's code for this function. What we get from Chimera isn't working for our backend service.

@gbajaj91 gbajaj91 marked this pull request as ready for review May 24, 2024 07:45
@gbajaj91 gbajaj91 changed the title New swc test Adding new spectrum component to milo lib May 24, 2024
@qiyundai qiyundai merged commit 0691283 into stage May 24, 2024
5 checks passed
@qiyundai qiyundai deleted the new-swc-test branch December 23, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants