Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding repeatable element using a repeat block #1

Merged
merged 8 commits into from
May 9, 2024
Merged

Adding repeatable element using a repeat block #1

merged 8 commits into from
May 9, 2024

Conversation

gbajaj91
Copy link
Collaborator

@gbajaj91 gbajaj91 commented May 7, 2024 •
edited by qiyundai
Loading

Describe your specific features or fixes
Added a repeat element controller and delete functionality.

Resolves: MWPW-147085

Test URLs:

@gbajaj91 gbajaj91 requested a review from qiyundai May 7, 2024 16:56
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 7, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@gbajaj91 gbajaj91 changed the title Gbajaj repeat element Adding repeatable element using a repeat block May 7, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to gbajaj-repeat-element May 7, 2024 17:00 Inactive
@qiyundai
Copy link
Collaborator

qiyundai commented May 7, 2024

@gbajaj91 this looks good! Do you want to merge some reusable functions to a place (maybe share-controller.js) for now so that other works can start to potentially leverage it?

@aem-code-sync aem-code-sync bot temporarily deployed to gbajaj-repeat-element May 8, 2024 07:11 Inactive
qiyundai
qiyundai requested changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@qiyundai qiyundai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Can we also remove the FPO integration in the event-info component and move the styling to the form-handler.css?

@aem-code-sync aem-code-sync bot temporarily deployed to gbajaj-repeat-element May 9, 2024 04:49 Inactive
@qiyundai qiyundai changed the base branch from main to stage May 9, 2024 15:45
@aem-code-sync aem-code-sync bot temporarily deployed to gbajaj-repeat-element May 9, 2024 16:04 Inactive
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 9, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

qiyundai
qiyundai approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@qiyundai qiyundai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged to unblock some other works

@qiyundai qiyundai marked this pull request as ready for review May 9, 2024 21:47
@qiyundai qiyundai merged commit 15e9ad5 into stage May 9, 2024
6 checks passed
rayyank10 added a commit that referenced this pull request Jul 26, 2024
@rayyank10
Merge pull request #126 from adobecom/dev
42aa785 
Dev -> Stage July 26 #1
apganapa-adobe added a commit that referenced this pull request Jul 29, 2024
@apganapa-adobe
Merge pull request #137 from adobecom/dev
5c071ce 
Dev -> Stage July 29th #1
apganapa-adobe added a commit that referenced this pull request Aug 5, 2024
@apganapa-adobe
Merge pull request #144 from adobecom/dev
f40eb79 
Dev -> Stage Aug 1st #1
apganapa-adobe pushed a commit that referenced this pull request Aug 9, 2024
@qiyundai
[MWPW-156139] Dashboard Columns Update #1 (#160)
9cafea7
@qiyundai qiyundai deleted the gbajaj-repeat-element branch December 23, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiyundai qiyundai qiyundai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbajaj91 @qiyundai