Mwpw 158926 company name wrap #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2024 16:22
…ap long names to next line)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #82 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 10 10
Lines 3179 3179
=======================================
Hits 2657 2657
Misses 522 522 ☔ View full report in Codecov by Sentry. |
cod17828
approved these changes
Oct 7, 2024
zagi25
requested changes
Oct 7, 2024
| @@ -24,6 +24,13 @@ | |||
| transform: translate3d(0,0,0); /* Fix Safari issues w/ position: sticky */ | |||
| } | |||
|
|
|||
| /*MWPW-158926*/ | |||
| .feds-profile-menu { | |||
There was a problem hiding this comment.
Solution is good, but I think we should keep the way we write the css selectors consistent
.feds-profile-menu .company-placeholder
richardhand-fortedigital
approved these changes
Oct 7, 2024
zagi25
approved these changes
Oct 7, 2024
|
@SonjaPopovic I think the "before" should be the URL on the stage branch, not partner-stage.adobe.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
https://stage--dme-partners--adobecom.hlx.page/channelpartners/home/
after: https://mwpw-158926-company-name-wrap--dme-partners--adobecom.hlx.page/channelpartners/home/?georouting=off