Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-161359: Just set path to card link #118

Merged
merged 2 commits into from
Nov 5, 2024
Merged

MWPW-161359: Just set path to card link #118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee261d8
MWPW-161359: Just set path to card link
zagi25 Nov 4, 2024
89781f6
MWPW-161359: Update card url to support non milo urls
zagi25 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion edsdme/blocks/announcements-preview/announcements-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { getConfig } from '../utils/utils.js';
function addAnnouncement(cardData) {
const linkWrapper = document.createElement('a');
linkWrapper.className = 'link-wrapper';
linkWrapper.href = cardData.contentArea.url;
const cardUrl = new URL(cardData.contentArea.url);
linkWrapper.href = cardUrl.pathname;
linkWrapper.target = '_blank';
zagi25 marked this conversation as resolved.
Show resolved Hide resolved

linkWrapper.style.display = 'block';
Expand Down
Loading