MWPW-161280: Update setLibs so it points to .adobe.com/libs #115
Conversation
zagi25
requested review from
Ben-Zahler,
SonjaPopovic,
cod17828 and
dejanpreradovic
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #115 +/- ##
==========================================
- Coverage 82.64% 82.50% -0.14%
==========================================
Files 10 10
Lines 3249 3253 +4
==========================================
- Hits 2685 2684 -1
- Misses 564 569 +5 ☔ View full report in Codecov by Sentry. |
| const partnerBranch = hostname.startsWith('main') ? 'main' : 'stage'; | ||
| const branch = new URLSearchParams(search).get('milolibs') || partnerBranch; | ||
| if (branch === 'local') { | ||
| return 'http://localhost:6456/libs'; |
There was a problem hiding this comment.
why port 6456? never seen this port before
There was a problem hiding this comment.
@Ben-Zahler this is the default milo port for when you want to get milo code from your machine so you can debug it. Milo repo has command npm run libs, this will spin up server on port 6456 and when you set query param milolibs=local in your url, you fetch milo code from that server and any local changes that you make to milo repo will be reflected on your page.
Milo libs:
milolibsquery param works only on.hlx.{page/live}linksResolves: MWPW-161280
Before: https://stage--dme-partners--adobecom.hlx.live/channelpartners/
After: https://mwpw-161280-milolibs--dme-partners--adobecom.hlx.live/channelpartners/