Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154138 - gnav search #100

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

richardhand-fortedigital
Copy link
Collaborator

@richardhand-fortedigital richardhand-fortedigital commented Oct 21, 2024

- adds suggestions to global nav search
Copy link

aem-code-sync bot commented Oct 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Oct 21, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (6c40c9d) to head (1d9470b).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #100   +/-   ##
=======================================
  Coverage   83.51%   83.51%           
=======================================
  Files          10       10           
  Lines        3209     3209           
=======================================
  Hits         2680     2680           
  Misses        529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

headers.append('Content-Type', 'application/json');
headers.append('Authorization', 'Basic NDA3M2UwZTgtMTNlMC00ZjZjLWI5ZTMtZjBhZmQwYWM0ZDMzOjJKMnY1ODdnR3dtVXhoQjNRNlI2NDIydlJNUDYwRDZBYnJtSzRpRTJrMDBmdlI1VGMxRXNRbG9Vc2dBYTNNSUg=');

return fetch(url.toString(), { headers })
.then((data) => data.json())
Copy link
Collaborator

@SonjaPopovic SonjaPopovic Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to move logic for fetch headers and query params in some utils file since we already have this on one more place

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, and we'll need it again in the suggestions UI you're working on. Makes sense to me

@richardhand-fortedigital richardhand-fortedigital merged commit 6b3a5d0 into stage Oct 22, 2024
15 of 16 checks passed
@richardhand-fortedigital richardhand-fortedigital deleted the feat/MWPW-154138-gnav-search-ui branch October 22, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants