-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-154138 - gnav search #100
MWPW-154138 - gnav search #100
Conversation
- adds suggestions to global nav search
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #100 +/- ##
=======================================
Coverage 83.51% 83.51%
=======================================
Files 10 10
Lines 3209 3209
=======================================
Hits 2680 2680
Misses 529 529 ☔ View full report in Codecov by Sentry. |
headers.append('Content-Type', 'application/json'); | ||
headers.append('Authorization', 'Basic NDA3M2UwZTgtMTNlMC00ZjZjLWI5ZTMtZjBhZmQwYWM0ZDMzOjJKMnY1ODdnR3dtVXhoQjNRNlI2NDIydlJNUDYwRDZBYnJtSzRpRTJrMDBmdlI1VGMxRXNRbG9Vc2dBYTNNSUg='); | ||
|
||
return fetch(url.toString(), { headers }) | ||
.then((data) => data.json()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to move logic for fetch headers and query params in some utils file since we already have this on one more place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, and we'll need it again in the suggestions UI you're working on. Makes sense to me
before: https://stage--dme-partners--adobecom.hlx.page/channelpartners/drafts/richard/gnavsearch
now: https://feat-mwpw-154138-gnav-search-ui--dme-partners--adobecom.hlx.page/channelpartners/drafts/richard/gnavsearch