Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity Release #872

Merged
merged 21 commits into from
Oct 24, 2024
Merged

Unity Release #872

merged 21 commits into from
Oct 24, 2024

Conversation

Blainegunn
Copy link
Collaborator

Final batch of bugs and fixes before the Oct. 30 release

Copy link

aem-code-sync bot commented Oct 23, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.07317% with 34 lines in your changes missing coverage. Please review.

Project coverage is 84.78%. Comparing base (21181e4) to head (d72dcb1).
Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 9.67% 28 Missing ⚠️
acrobat/scripts/alloy/verb-widget.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   85.07%   84.78%   -0.29%     
==========================================
  Files          48       48              
  Lines        6091     6114      +23     
==========================================
+ Hits         5182     5184       +2     
- Misses        909      930      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

export default async function init(element) {
if (isOldBrowser()) {
window.location.href = EOLBrowserPage;
return;
}

const ENV = getEnv();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'ENV' is assigned a value but never used.

@Blainegunn Blainegunn merged commit b85b2ee into main Oct 24, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants