Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-152107 [EdgeWorker] Handle pages with unity workflow #871

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

TsayAdobe
Copy link
Collaborator

@TsayAdobe TsayAdobe commented Oct 23, 2024

  • Use the selector .unity.workflow-acrobat to decide if it's a unity page.
  • Exclude DC Converter Widget related embeddings.

Resolves: MWPW-152107

Test URL
Without EdgeWorker: https://www.stage.adobe.com/acrobat/online/test/sign-pdf.html
With EngeWorker: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Copy link

aem-code-sync bot commented Oct 23, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (d72dcb1) to head (2655b15).

Files with missing lines Patch % Lines
edgeworkers/Acrobat_DC_web_prod/main.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #871   +/-   ##
=======================================
  Coverage   84.78%   84.79%           
=======================================
  Files          48       48           
  Lines        6114     6117    +3     
=======================================
+ Hits         5184     5187    +3     
  Misses        930      930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TsayAdobe TsayAdobe changed the title MWPW-152107 Handle pages with unity workflow MWPW-152107 [EdgeWorker] Handle pages with unity workflow Oct 24, 2024
@TsayAdobe TsayAdobe marked this pull request as ready for review October 24, 2024 17:42
@Blainegunn Blainegunn merged commit c5eab8d into stage Oct 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants