DC Milo 0.2440 #838
DC Milo 0.2440 #838
Conversation
* stage: MWPW-158834 console logs for ez debug updates Eslint fix MWPW-158122 Add purge action command choice MWPW-158423 # Conflicts: # acrobat/blocks/verb-widget/verb-widget.js
MWPW-158599: Dynamic prefetch from anon on unity workflow
Text decoration under verb widget footer links
* stage: Lint fix Eslint fix Dynamic prefetch from anon on unity workflow
MWPW-157037: Nonprofit completed scenarios
MWPW-157037: Removed hidden overflow for logo
MWPW-157776 Prompt Card Block
MWPW-157780 Update based on design audit
MWPW-157037: Nonprofit handover
implemented support for susi buttons
MWPW-159091 Add analytics event for clicking a prompt card
MWPW-158477
MWPW-158477
MWPW-159032: Verb Widget - Accessibility Issues
MWPW-158176: RNR- Updated production url
MWPW-159421
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
===========================================
+ Coverage 69.03% 88.73% +19.69%
===========================================
Files 47 51 +4
Lines 7196 7805 +609
===========================================
+ Hits 4968 6926 +1958
+ Misses 2228 879 -1349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| footer.append(iconSecurity, legal); | ||
|
|
||
| element.append(widget, footer); | ||
|
|
||
| // Redirect after IMS:Ready | ||
| window.addEventListener('IMS:Ready', () => { | ||
| console.log('IMS:Ready 😎'); |
There was a problem hiding this comment.
Unexpected console statement.
| // Race Condition | ||
| if (window.adobeIMS?.isSignedInUser() | ||
| && window.adobeIMS?.getAccountType() !== 'type1') { | ||
| console.log('Race Con ⏩'); |
There was a problem hiding this comment.
Unexpected console statement.
| export default function init(eventName, verb) { | ||
| console.log(`📡 Event Name - acrobat:verb-${verb}:${eventName}`); | ||
| export default function init(eventName, verb, metaData) { | ||
| console.log(`📡 Event Name - acrobat:verb-${verb}:${eventName} - metaData: ${metaData?.type} / ${metaData?.size} `); |
There was a problem hiding this comment.
Unexpected console statement.
| import { readFile } from '@web/test-runner-commands'; | ||
| import { expect } from '@esm-bundle/chai'; | ||
| import sinon from 'sinon'; | ||
| import { waitForElement, delay } from '../../helpers/waitfor.js'; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'waitForElement' is defined but never used.
| document.body.innerHTML = await readFile({ path: './mocks/body-json-more-less.html' }); | ||
| await import('../../../acrobat/scripts/scripts.js'); | ||
| await delay(500); | ||
| await new Promise((resolve) => requestAnimationFrame(resolve)); |
There was a problem hiding this comment.
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
| import { readFile } from '@web/test-runner-commands'; | ||
| import { expect } from '@esm-bundle/chai'; | ||
| import sinon from 'sinon'; | ||
| import { waitForElement, delay } from '../../helpers/waitfor.js'; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'waitForElement' is defined but never used.
| document.body.innerHTML = await readFile({ path: './mocks/body-json-more.html' }); | ||
| await import('../../../acrobat/scripts/scripts.js'); | ||
| await delay(500); | ||
| await new Promise((resolve) => requestAnimationFrame(resolve)); |
There was a problem hiding this comment.
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
| @@ -1,15 +1,16 @@ | |||
| import { expect } from '@esm-bundle/chai'; | |||
| import { waitForElement } from '../helpers/waitfor.js'; | |||
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'waitForElement' is defined but never used.
Release Notes: DC Milo 0.2440