Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157037: Nonprofit handover #832

Merged
merged 4 commits into from
Sep 30, 2024
Merged

MWPW-157037: Nonprofit handover #832

merged 4 commits into from
Sep 30, 2024

Conversation

st-angelo-adobe
Copy link
Collaborator

Copy link

aem-code-sync bot commented Sep 30, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 30, 2024

Page Scores Audits Google
📱 /drafts/astatescu/nonprofit/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/astatescu/nonprofit/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 89.35361% with 28 lines in your changes missing coverage. Please review.

Project coverage is 89.25%. Comparing base (07a5da4) to head (d9cb250).

Files with missing lines Patch % Lines
acrobat/blocks/nonprofit/nonprofit.js 88.39% 26 Missing ⚠️
acrobat/blocks/nonprofit/nonprofit-select.js 81.81% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            stage     #832       +/-   ##
===========================================
+ Coverage   67.49%   89.25%   +21.75%     
===========================================
  Files          48       49        +1     
  Lines        7658     7762      +104     
===========================================
+ Hits         5169     6928     +1759     
+ Misses       2489      834     -1655     
Flag Coverage Δ
89.25% <89.35%> (+21.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blainegunn Blainegunn merged commit 94b5c70 into stage Sep 30, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants