Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-158122 #831

Merged
merged 1 commit into from
Sep 26, 2024
Merged

MWPW-158122 #831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions acrobat/blocks/verb-widget/verb-widget.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 141 in fe9573d

console.log('IMS:Ready 😎');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 150 in fe9573d

console.log('Race Con ⏩');

Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export default async function init(element) {

button.addEventListener('click', () => {
verbAnalytics('filepicker:shown', VERB);
verbAnalytics('dropzone:choose-file-clicked', VERB);
initiatePrefetch(VERB);
});

Expand Down Expand Up @@ -191,7 +192,7 @@ export default async function init(element) {

window.addEventListener('unity:track-analytics', (e) => {
if (e.detail?.event === 'change') {
verbAnalytics('choose-file:open', VERB);
verbAnalytics('choose-file:open', VERB, e.detail?.data);
setUser();
}
// maybe new event name files-dropped?
Expand All @@ -200,10 +201,6 @@ export default async function init(element) {
setDraggingClass(widget, false);
setUser();
}
if (e.detail?.event === 'choose-file-clicked') {
verbAnalytics('dropzone:choose-file-clicked', VERB, e.detail?.data);
setUser();
}

if (e.detail?.event === 'uploading') {
verbAnalytics('job:uploading', VERB, e.detail?.data);
Expand Down
Loading