MWPW-159091 Add analytics event for clicking a prompt card #829
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsayAdobe
requested review from
joaquinrivero,
tedAir,
Blainegunn and
saragajic11
|
Blainegunn
reviewed
Sep 27, 2024
| @@ -37,6 +38,7 @@ async function createBlock(element, cfg) { | |||
| 'data-toast': cfg.toast, | |||
| 'daa-im': true, | |||
| 'daa-lh': 'Featured prompts | Executive summary', | |||
There was a problem hiding this comment.
will this remain hard coded?
There was a problem hiding this comment.
Could we have a default behavior and an option for authors to switch in case is need it?
Blainegunn
approved these changes
Sep 27, 2024
joaquinrivero
approved these changes
Sep 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #829 +/- ##
==========================================
+ Coverage 88.74% 88.76% +0.01%
==========================================
Files 51 51
Lines 7809 7812 +3
==========================================
+ Hits 6930 6934 +4
+ Misses 879 878 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: MWPW-159091
Test URLs:
Before: https://promptcard--dc--adobecom.hlx.live/drafts/tsay/prompt-cards-template-group
After: https://promptcard-analytics--dc--adobecom.hlx.live/drafts/tsay/prompt-cards-template-group