Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC MILO Release 0.2439 #821

Merged
merged 20 commits into from
Sep 24, 2024
Merged

DC MILO Release 0.2439 #821

merged 20 commits into from
Sep 24, 2024

Conversation

joaquinrivero
Copy link
Collaborator

@joaquinrivero joaquinrivero added this to the 0.2439 milestone Sep 24, 2024
Copy link

aem-code-sync bot commented Sep 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 14.68927% with 151 lines in your changes missing coverage. Please review.

Project coverage is 69.03%. Comparing base (5b63036) to head (290a911).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 8.33% 77 Missing ⚠️
acrobat/scripts/alloy/verb-widget.js 19.73% 61 Missing ⚠️
acrobat/blocks/unity/unity.js 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   70.45%   69.03%   -1.43%     
==========================================
  Files          47       47              
  Lines        7109     7196      +87     
==========================================
- Hits         5009     4968      -41     
- Misses       2100     2228     +128     
Flag Coverage Δ
69.03% <14.68%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blainegunn Blainegunn merged commit e847e23 into main Sep 24, 2024
41 of 60 checks passed
redDir(VERB);
// Errors, Analytics & Logging
window.addEventListener('unity:show-error-toast', (e) => {
console.log(`⛔️ Error Code - ${e.detail?.code}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

});
}

// const ce = (new CustomEvent('unity:show-error-toast', { detail: { code: 'only_accept_one_file', message: 'Error message' } }));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 130. Maximum allowed is 100.

export default function init(eventName, verb) {
console.log(`📡 Event Name - acrobat:verb-${verb}:${eventName}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants