MWPW-158944 #820
Merged
MWPW-158944 #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blainegunn
requested review from
saragajic11,
TsayAdobe,
Ruchika4 and
sanjayms01
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| export default function init(eventName, verb) { | ||
| console.log(`📡 Event Name - acrobat:verb-${verb}:${eventName}`); | ||
| export default function init(eventName, verb, metaData) { | ||
| console.log(`📡 Event Name - acrobat:verb-${verb}:${eventName} - metaData: ${metaData?.type} / ${metaData?.size} `); |
There was a problem hiding this comment.
Unexpected console statement.
sanjayms01
reviewed
Sep 23, 2024
Comment on lines
153
to
177
| if (e.detail?.code === 'only_accept_one_file') { | ||
| handleError(errorState, errorStateText, 'verb-widget-error-multi'); | ||
| handleError(e.detail?.message); | ||
| verbAnalytics('error', VERB); | ||
| } | ||
|
|
||
| if (e.detail?.code === 'unsupported_type') { | ||
| handleError(errorState, errorStateText, 'verb-widget-error-unsupported'); | ||
| handleError(e.detail?.message); | ||
| verbAnalytics('error:unsupported_type', VERB); | ||
| } | ||
|
|
||
| if (e.detail?.code === 'empty_file') { | ||
| handleError(errorState, errorStateText, 'verb-widget-error-empty'); | ||
| handleError(e.detail?.message); | ||
| verbAnalytics('error:empty_file', VERB); | ||
| } | ||
|
|
||
| // Code may be wrong. should be 'file_too_large' | ||
| if (e.detail?.code === 'file_too_largempty_file') { | ||
| handleError(errorState, errorStateText, 'verb-widget-error-large', LIMITS[VERB].maxFileSizeFriendly); | ||
| handleError(e.detail?.message); | ||
| verbAnalytics('error', VERB); | ||
| } | ||
|
|
||
| if (e.detail?.code === 'max_page_count') { | ||
| handleError(errorState, errorStateText, 'verb-widget-error-max', LIMITS[VERB].maxNumFiles); | ||
| handleError(e.detail?.message); | ||
| verbAnalytics('error:max_page_count', VERB); | ||
| } |
There was a problem hiding this comment.
The codes that we send will be based off title.single.code in this sheet: fillsign.xlsx. Could we update these equality checks to includes() instead?
There was a problem hiding this comment.
maybe @amitbikram can confirm reasoning behind using this specific format (ie. verb_upload_error...)?
There was a problem hiding this comment.
Sorry I will need error in the prefix for the code to distinguish on unity end, but verb_upload seems extraneous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : MWPW-158944