Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented support for susi buttons #819

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

saragajic11
Copy link
Collaborator

@saragajic11 saragajic11 commented Sep 23, 2024

Resolves: MWPW-158072

Before:
https://main--dc--adobecom.hlx.page/drafts/sara/susi

After:
https://mwpw-158072-sign-in-link-support--dc--adobecom.hlx.page/drafts/sara/susi

Important: CORS is blocking the IMS:Ready event to be fired, so make sure you are using 'CORS unblock' or some other plugin to achieve the expected behaviour

Copy link

aem-code-sync bot commented Sep 23, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 23, 2024

Page Scores Audits Google
📱 /drafts/sara/susi PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/sara/susi PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 6.52174% with 43 lines in your changes missing coverage. Please review.

Project coverage is 68.62%. Comparing base (46ba26b) to head (e0361b0).
Report is 3 commits behind head on stage.

Files with missing lines Patch % Lines
acrobat/scripts/susiAuthHandler.js 0.00% 21 Missing ⚠️
acrobat/scripts/alloy/susi-auth-handler.js 0.00% 17 Missing ⚠️
acrobat/scripts/scripts.js 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #819      +/-   ##
==========================================
- Coverage   69.02%   68.62%   -0.40%     
==========================================
  Files          47       49       +2     
  Lines        7196     7242      +46     
==========================================
+ Hits         4967     4970       +3     
- Misses       2229     2272      +43     
Flag Coverage Δ
68.62% <6.52%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158072-sign-in-link-support September 23, 2024 12:35 Inactive
Copy link
Collaborator

@Blainegunn Blainegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason for these changes is to reduce the number of document.querySelectorAll we call since they all hurt performance.

acrobat/scripts/scripts.js Outdated Show resolved Hide resolved
acrobat/scripts/scripts.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158072-sign-in-link-support September 24, 2024 08:20 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158072-sign-in-link-support September 24, 2024 08:25 Inactive
@saragajic11
Copy link
Collaborator Author

The main reason for these changes is to reduce the number of document.querySelectorAll we call since they all hurt performance.

thanks @Blainegunn !

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158072-sign-in-link-support September 24, 2024 09:05 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158072-sign-in-link-support September 24, 2024 09:09 Inactive
@saragajic11 saragajic11 added this to the 0.2440 milestone Sep 24, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158072-sign-in-link-support September 25, 2024 09:05 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-158072-sign-in-link-support September 27, 2024 15:22 Inactive
@Blainegunn Blainegunn merged commit 2dcde60 into stage Sep 30, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants