-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented support for susi buttons #819
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #819 +/- ##
==========================================
- Coverage 69.02% 68.62% -0.40%
==========================================
Files 47 49 +2
Lines 7196 7242 +46
==========================================
+ Hits 4967 4970 +3
- Misses 2229 2272 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason for these changes is to reduce the number of document.querySelectorAll
we call since they all hurt performance.
thanks @Blainegunn ! |
Resolves: MWPW-158072
Before:
https://main--dc--adobecom.hlx.page/drafts/sara/susi
After:
https://mwpw-158072-sign-in-link-support--dc--adobecom.hlx.page/drafts/sara/susi
Important: CORS is blocking the IMS:Ready event to be fired, so make sure you are using 'CORS unblock' or some other plugin to achieve the expected behaviour