Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready for Main: stage into main. #597

Closed
wants to merge 14 commits into from
Closed

Ready for Main: stage into main. #597

wants to merge 14 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 5, 2024

Merge to main, commit: 1906be4 --

Copy link

aem-code-sync bot commented Mar 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@@ -291,6 +291,9 @@ const CONFIG = {
version: '1.0',
onDemand: false,
},
htmlExclude: [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.

Suggested change
htmlExclude: [
htmlExclude: [

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 98.72%. Comparing base (31c190f) to head (3e91532).
Report is 49 commits behind head on main.

Files Patch % Lines
acrobat/scripts/scripts.js 58.82% 7 Missing ⚠️
acrobat/scripts/geo-phoneNumber.js 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   98.91%   98.72%   -0.19%     
==========================================
  Files          32       33       +1     
  Lines        3857     3936      +79     
==========================================
+ Hits         3815     3886      +71     
- Misses         42       50       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TsayAdobe and others added 2 commits March 6, 2024 14:28
Test EdgeWorker deployment on Acom stage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants