MWPW-135230 DC Widget Backup / Logging Improvements #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
|
Blainegunn
changed the title
Blainegunn
requested review from
seanchoi-dev,
TsayAdobe,
draganatrajkovic,
zagi25 and
puruadobe
peller
reviewed
Aug 19, 2023
| if (!DC_WIDGET_VERSION) { | ||
| DC_WIDGET_VERSION = DC_WIDGET_VERSION_FALLBACK; | ||
| window.lana?.log(`DC WIDGET VERSION IS NOT SET, USING FALLBACK VERSION: ${DC_WIDGET_VERSION_FALLBACK}`, lanaOptions); | ||
| dcwErrors.push(`DC WIDGET VERSION IS NOT SET, USING FALLBACK VERSION: ${DC_WIDGET_VERSION_FALLBACK}`); |
There was a problem hiding this comment.
should these reference window.dcwErrors ?
There was a problem hiding this comment.
I meant to ask whether this line should be changed to include window.. Probably only a lint issue.
peller
reviewed
Aug 19, 2023
| } | ||
| if (!DC_GENERATE_CACHE_VERSION) { | ||
| DC_GENERATE_CACHE_VERSION = DC_GENERATE_CACHE_VERSION_FALLBACK; | ||
| window.lana?.log(`DC GENERATE CACHE VERSION IS NOT SET, USING FALLBACK VERSION: ${DC_GENERATE_CACHE_VERSION_FALLBACK}`, lanaOptions); | ||
| dcwErrors.push(`DC GENERATE CACHE VERSION IS NOT SET, USING FALLBACK VERSION: ${DC_GENERATE_CACHE_VERSION_FALLBACK}`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : MWPW-135230
LANA Logs for DC Widget were being skipped due to the fast tracking; fixed as well.
https://mwpw-135230--dc--adobecom.hlx.page/acrobat/online/john-test-verb?lanaDebug
https://mwpw-135230--dc--adobecom.hlx.page/documentcloud/merge-pdf-nopersonal?lanaDebug