Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetch dc core #309

Closed
wants to merge 3 commits into from
Closed

Prefetch dc core #309

wants to merge 3 commits into from

Conversation

peller
Copy link
Collaborator

@peller peller commented Aug 6, 2023

No description provided.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 6, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@codecov-commenter
Copy link

Codecov Report

Merging #309 (69d1330) into stage (7c783a6) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            stage     #309      +/-   ##
==========================================
- Coverage   88.15%   88.12%   -0.03%     
==========================================
  Files          27       27              
  Lines        2592     2594       +2     
==========================================
+ Hits         2285     2286       +1     
- Misses        307      308       +1     
Files Changed Coverage Δ
acrobat/scripts/scripts.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 7, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/fr/acrobat/online/sign-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/fr/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 8, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/fr/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/fr/acrobat/online/sign-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 8, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/fr/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/sign-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@seanchoi-dev
Copy link
Collaborator

I updated few stuff to match ESLINT rules and resolved the merge conflict from stage.

@seanchoi-dev seanchoi-dev self-requested a review August 8, 2023 23:14
@Blainegunn Blainegunn closed this Aug 16, 2023
@Blainegunn Blainegunn deleted the prefetch-dc-core branch August 17, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants