Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace hard-coded version with variable #308

Merged
merged 1 commit into from
Aug 7, 2023
Merged

replace hard-coded version with variable #308

merged 1 commit into from
Aug 7, 2023

Conversation

peller
Copy link
Collaborator

@peller peller commented Aug 6, 2023

dc-hosted/generate cache will always be the second half of the widget version tuple

@peller peller requested a review from Blainegunn August 6, 2023 02:27
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 6, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@codecov-commenter
Copy link

Codecov Report

Merging #308 (9b7e0df) into stage (7c783a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            stage     #308   +/-   ##
=======================================
  Coverage   88.15%   88.16%           
=======================================
  Files          27       27           
  Lines        2592     2593    +1     
=======================================
+ Hits         2285     2286    +1     
  Misses        307      307           
Files Changed Coverage Δ
acrobat/scripts/scripts.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Blainegunn Blainegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Blainegunn Blainegunn merged commit a94bf46 into stage Aug 7, 2023
3 of 5 checks passed
@Blainegunn Blainegunn deleted the prefetch branch August 7, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants