Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-132721: Removed promotion block from codebase #300

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

zagi25
Copy link
Collaborator

@zagi25 zagi25 commented Aug 3, 2023

Please note, on after page Promotion block is failing to load because it is used in fragment that is defined in footer-promo-tag. I notified Holly that we are removing Promotion block and when she removes it, everything should be working as expected.

Resolves: MWPW-132721

Before: https://stage--dc--adobecom.hlx.live/acrobat/hub/how-to-convert-heic-to-jpg-on-a-mac

After: https://mwpw-132721-remove-promotion-block--dc--adobecom.hlx.live/acrobat/hub/how-to-convert-heic-to-jpg-on-a-mac

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 3, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 3, 2023

Page Scores Audits Google
/acrobat/hub/how-to-convert-heic-to-jpg-on-a-mac Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 3, 2023

Page Scores Audits Google
/acrobat/hub/how-to-convert-heic-to-jpg-on-a-mac Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #300 (b43d47f) into stage (f101d28) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #300      +/-   ##
==========================================
- Coverage   88.22%   87.75%   -0.47%     
==========================================
  Files          27       26       -1     
  Lines        2590     2556      -34     
==========================================
- Hits         2285     2243      -42     
- Misses        305      313       +8     
Files Changed Coverage Δ
acrobat/blocks/list.js 100.00% <ø> (ø)
acrobat/scripts/scripts.js 96.89% <ø> (-3.11%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 4, 2023

Page Scores Audits Google
/acrobat/hub/how-to-convert-heic-to-jpg-on-a-mac Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

Copy link
Collaborator

@Blainegunn Blainegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great, but not ready to merge until we relocate the promos in sharepoint

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 7, 2023

Page Scores Audits Google
/acrobat/hub/how-to-convert-heic-to-jpg-on-a-mac PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@seanchoi-dev seanchoi-dev merged commit 39569f7 into stage Aug 17, 2023
8 checks passed
@seanchoi-dev seanchoi-dev deleted the MWPW-132721-remove-promotion-block branch August 17, 2023 15:07
@JFernandezAdobe JFernandezAdobe added this to the 0.2334 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants