Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added padding for how-to block #294

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Added padding for how-to block #294

merged 6 commits into from
Aug 4, 2023

Conversation

saragajic11
Copy link
Collaborator

@saragajic11 saragajic11 commented Jul 31, 2023

*Added padding to how-to block to fix overlapping on tablet devices + added additional padding for desktop devices to match previous design

Resolves: MWPW-134277

Test URLs:

Before: https://stage--dc--adobecom.hlx.page/acrobat/online/word-to-pdf
After: https://mwpw-134277-fix-overlap--dc--adobecom.hlx.page/acrobat/online/word-to-pdf

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 31, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 31, 2023

Page Scores Audits Google
/acrobat/online/word-to-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #294 (e958987) into stage (3eb40fa) will increase coverage by 0.04%.
Report is 12 commits behind head on stage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            stage     #294      +/-   ##
==========================================
+ Coverage   99.46%   99.51%   +0.04%     
==========================================
  Files          26       26              
  Lines        2261     2255       -6     
==========================================
- Hits         2249     2244       -5     
+ Misses         12       11       -1     
Files Changed Coverage Δ
.../blocks/dc-converter-widget/dc-converter-widget.js 100.00% <100.00%> (ø)
acrobat/scripts/maps/localeMap.js 100.00% <100.00%> (ø)
acrobat/scripts/scripts.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

acrobat/styles/styles.css Outdated Show resolved Hide resolved
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/acrobat/online/word-to-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/acrobat/online/word-to-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/acrobat/online/word-to-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/acrobat/online/word-to-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

Copy link
Collaborator

@zagi25 zagi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saragajic11 This looks good but I just realized that this will affect all of our pages that uses how-to block, so you should target how-to only if it is inside eventwrapper :

.eventwrapper  .how-to-heading { 
    ...
 }

etc.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 2, 2023

Page Scores Audits Google
/acrobat/online/word-to-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

Copy link
Collaborator

@zagi25 zagi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everyone is okay with extra padding on smaller devices, then this is fine by me. Great job @saragajic11 !

@Blainegunn Blainegunn merged commit 56b16ab into stage Aug 4, 2023
3 of 5 checks passed
@Blainegunn Blainegunn deleted the mwpw-134277-fix-overlap branch August 7, 2023 17:10
@JFernandezAdobe JFernandezAdobe added this to the 0.2332 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants