-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added padding for how-to block #294
Conversation
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Codecov Report
@@ Coverage Diff @@
## stage #294 +/- ##
==========================================
+ Coverage 99.46% 99.51% +0.04%
==========================================
Files 26 26
Lines 2261 2255 -6
==========================================
- Hits 2249 2244 -5
+ Misses 12 11 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saragajic11 This looks good but I just realized that this will affect all of our pages that uses how-to
block, so you should target how-to
only if it is inside eventwrapper
:
.eventwrapper .how-to-heading {
...
}
etc.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If everyone is okay with extra padding on smaller devices, then this is fine by me. Great job @saragajic11 !
*Added padding to how-to block to fix overlapping on tablet devices + added additional padding for desktop devices to match previous design
Resolves: MWPW-134277
Test URLs:
Before: https://stage--dc--adobecom.hlx.page/acrobat/online/word-to-pdf
After: https://mwpw-134277-fix-overlap--dc--adobecom.hlx.page/acrobat/online/word-to-pdf