Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP Update #289

Merged
merged 7 commits into from
Aug 16, 2023
Merged

CSP Update #289

merged 7 commits into from
Aug 16, 2023

Conversation

dc-csp-update
Copy link
Collaborator

No description provided.

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 24, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 24, 2023

Page Scores Audits Google
/acrobat/online/sign-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/fr/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

'api.ultimateadb.com',
'c.clicktale.net',
'cdnmd.global-cache.online',
'ff.kis.v2.scr.kaspersky-labs.com',
Copy link
Collaborator

@peller peller Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we deliberately put kaspersky-labs on our page, or is this just something we see rejected in the field (because people have anti-virus software installed)? If the latter, we probably do NOT want it on the allow list

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did security review this list?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can speak w/ security

Copy link
Collaborator

@peller peller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting a hold on this until it is reviewed.

@Blainegunn Blainegunn added the trivial PR doesn't require E2E testing by a reviewer label Aug 16, 2023
@Blainegunn Blainegunn merged commit 39ea4fb into stage Aug 16, 2023
3 of 6 checks passed
@Blainegunn Blainegunn deleted the csp-update-branch branch August 17, 2023 14:32
@peller peller mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants