MWPW-129281 - CLS Regression #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 20, 2023 11:50
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
peller
reviewed
Jun 20, 2023
| @@ -92,6 +93,7 @@ export default function init(element) { | |||
| break; | |||
| case UPLOAD_START: | |||
| setCurrentEvent('upload'); | |||
| if (reviewBlock[0]) { reviewBlock[0].classList.add('fade'); }; | |||
There was a problem hiding this comment.
you might want to hide it immediately on upload (simultaneously or prior to shifting the content upward) then fade it back in after the upload completes? It might even be possible to do this with only CSS rules
added 2 commits
July 20, 2023 14:47
Codecov Report
@@ Coverage Diff @@
## stage #267 +/- ##
==========================================
- Coverage 99.68% 99.42% -0.27%
==========================================
Files 26 26
Lines 2220 2243 +23
==========================================
+ Hits 2213 2230 +17
- Misses 7 13 +6
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : MWPW-129281