Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main 10/03 #429

Merged
merged 8 commits into from
Oct 22, 2024
Merged

[Release] Stage to Main 10/03 #429

merged 8 commits into from
Oct 22, 2024

Conversation

milo-pr-merge-cc[bot]
Copy link

@milo-pr-merge-cc milo-pr-merge-cc bot commented Oct 3, 2024 •
edited
Loading

@milo-pr-merge-cc
Copy link
Author

Testing can start @adobecom/creative-cloud-sot

@milo-pr-merge-cc milo-pr-merge-cc bot requested a review from a team as a code owner October 3, 2024 08:19
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 3, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 3, 2024 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Blainegunn @salonijain3
MWPW-159357 (#428)
a78f9b2 
Co-authored-by: Saloni Jain <[email protected]>
@spadmasa spadmasa added verified ready for main PR is ready to be merged to main branch labels Oct 4, 2024
@mirafedas @Axelcureno
MWPW-158911: Unable to scroll page if the filters modal closed by cli…
491ef09 
…ck outside of the modal (#412)

* fixed scrolling after click outside

* merch-sidenav is taken from Milo now

* debug

* debug

* debug

* fixed libs path in unit tests

---------

Co-authored-by: Axel Cureno Basurto <[email protected]>
@salonijain3
Copy link
Collaborator

https://adobe.service-now.com/now/nav/ui/classic/params/target/change_request.do%3Fsys_id%3Db1443b3247dd1210dff288ba116d435a

@salonijain3 salonijain3 merged commit b947bc8 into main Oct 22, 2024
5671 of 5672 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhjainadobe suhjainadobe suhjainadobe approved these changes

@aishwaryamathuria aishwaryamathuria aishwaryamathuria approved these changes

@amitbikram amitbikram Awaiting requested review from amitbikram

@salonijain3 salonijain3 Awaiting requested review from salonijain3

@drashti1712 drashti1712 Awaiting requested review from drashti1712

@Ruchika4 Ruchika4 Awaiting requested review from Ruchika4

Assignees

@spadmasa spadmasa

@sigadamvenkata sigadamvenkata

Labels
ready for main PR is ready to be merged to main branch verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@spadmasa @salonijain3 @aishwaryamathuria @suhjainadobe @sigadamvenkata @joaquinrivero @Blainegunn @Ruchika4 @mirafedas