Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-142006 - Enable repo-sync for graybox #263

Merged
merged 1 commit into from
Apr 11, 2024
Merged

MWPW-142006 - Enable repo-sync for graybox #263

merged 1 commit into from
Apr 11, 2024

Conversation

arshadparwaiz
Copy link
Collaborator

@arshadparwaiz arshadparwaiz commented Apr 9, 2024 •
edited by aishwaryamathuria
Loading

  • Enable CC repo-sync for CC graybox repo

Resolves: MWPW-142006

@arshadparwaiz arshadparwaiz requested a review from a team as a code owner April 9, 2024 21:35
@salonijain3
Copy link
Collaborator

@arshadparwaiz If this ready to be merged to stage, can you add the "ready for stage" label, does it need verification or is a trivial change?
IF it needs verification, please add the label and ask someone to verify and they will add the "verified" label.
The process is mentioned in https://github.com/adobecom/cc/wiki

@sukamat
Copy link
Contributor

sukamat commented Apr 10, 2024

@salonijain3 This cannot be verified before merging as it runs within github. That said, it has been validated in bacom repo. A copy of that script is now being created in other repos. Hope that provides some context.
adobecom/bacom#191

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 11, 2024

Page Scores Audits Google
/?martech=off&georouting=off Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@aishwaryamathuria aishwaryamathuria merged commit ea60f3c into adobecom:stage Apr 11, 2024
9 of 10 checks passed
@aishwaryamathuria aishwaryamathuria mentioned this pull request Apr 11, 2024
Merged
@aishwaryamathuria aishwaryamathuria added ready for main PR is ready to be merged to main branch and removed ready for main PR is ready to be merged to main branch labels Apr 11, 2024
@aishwaryamathuria
Copy link
Collaborator

@sukamat Could you confirm if this PR can be merged in main or if it needs some verification to be done before merging to main?
If It can be merged in main could you add "Ready for main" label
CC: @salonijain3

@sukamat
Copy link
Contributor

sukamat commented Apr 11, 2024

@arshadparwaiz could you validate the action and set the label as requested ?

@arshadparwaiz
Copy link
Collaborator Author

This github workflow is verified and working fine.
https://github.com/adobecom/cc/actions/runs/8653039191/job/23727321412
cc: @aishwaryamathuria @salonijain3 @sukamat

@arshadparwaiz arshadparwaiz added verified ready for main PR is ready to be merged to main branch labels Apr 12, 2024
aishwaryamathuria added a commit that referenced this pull request Apr 15, 2024
@aishwaryamathuria
[Release] Sync main from stage 11/4/2024 #266
e402af0 
Merging following PRs to main -

#246 MWPW-143951 | Optimize sidenav
#253 Better hlxignore
#257 MWPW-145840 | Fixing enticement for RTL locale in page of genfill
#263 MWPW-142006 | Enable repo-sync for graybox

---------------------------------- Interactive-Metadata ----------------------------------

#251 MWPW-142971 | Interactive web components over Marquee and Aside
#264 MWPW-146229 | Integrating review comments and new workflows for Interactive metadata
#265 MWPW-146219 | Hue Sat fix upload image icon
3ch023 added a commit to 3ch023/cc that referenced this pull request Jul 29, 2024
@3ch023 @sukamat
@aishwaryamathuria @suhjainadobe @Ruchika4 @salonijain3 @drashti1712 @honstar @nateekar @npeltier @yesil @sharg1 @seanchoi-dev @sharath-kannan @thedoc31 @rgclayton @arshadparwaiz @Blainegunn @sivasadobe
Catalog index (#1)
e3c30e5 
* Sidekick Update for new Floodgate endpoint

* Initial push for Interactive marquee

* FG admin page URL updated

* fixed merge conflicts

* Interactive marquee

* MWPW-137735: update sitemap index (adobecom#106)

* Interactive marquee

* Interactive marquee

* Interactive marquee

* Interactive marquee review

* MWPW-136654-Add meta tag to load 404 from centralized place in milo (adobecom#88)

* Update 404.html

* Update 404.html

* Update 404.html

* Update 404.html

* Update 404.html

* Update 404.html

* add meta tag for gnav and footer

* MWPW-138378-Sitemap update for batch 1C ROW (adobecom#112)

* Update helix-query.yaml

* Update helix-sitemap.yaml

* MWPW-138426-Firefly Interactive Marquee (adobecom#128)

* Firefly Interactive Marquee

* remove important from css

* remove unnecessary css class

---------

Co-authored-by: Ruchika Sinha <[email protected]>

* Genfill changes

* Update sitemap-index.xml (adobecom#120)

* Fix error when trying to submit sitemap to GSC (adobecom#136)

* Update sitemap-index.xml

* Update sitemap-index.xml

* fix enticement css (adobecom#137)

* MWPW-140091-[Firefly Marquee]implementation for new fix from product team (adobecom#135)

* Firefly Interactive Marquee

* remove important from css

* remove unnecessary css class

* MWPW-140091-implementation for new fix from product team

* add seed query param

---------

Co-authored-by: Ruchika Sinha <[email protected]>

* change background stage (adobecom#132)

Co-authored-by: Suhani Jain <[email protected]>

* Updating authoring for interactive elements (enticement, selector tray and Prompt bar) (adobecom#139)

* update authoring for interactive elements

* add cursor pointer

* fix interactive elem modes

* fix codeql error

* fix cursor for generative fill button

* remove pointer cursor from enticement and keep it only for image

* incorporate review comments

* fix codeQL error

* restrict interactive marquee css changes to firefly

* genfill pointer

---------

Co-authored-by: Ruchika Sinha <[email protected]>

* MWPW-140297- Set box-sizing for promptbar and selector tray in FF marquee (adobecom#142)

* Fix MWPW-140297

* set box sizing for selector tray also

* Decoding imgs

* Fixing async functions

* decoding imgs

* MWPW-140027-[FF IM]Fix blinking cursor in iOS when georouting pop up shows (adobecom#143)

* fix MWPW-140027

* optimize

* optimize

* remove webkit placeholder

---------

Co-authored-by: Ruchika Sinha <[email protected]>

* src approach

* src approach

* src approach

* src approach

* src approach

* added analytics

* Fixing UTs

* Fixed Safari issue

* Review changes

* Review changes

* UT fix

* alt fix

* set img attrs

* alt fix

* MWPW-139621 - LCP image loading of fragments
- implement decorateArea function from milo
- only run loadLCPImage function if no previous LCP image has been set already

* fix linting errors, add default case

* - fix bug with case statement, need boolean
- only eager load image in default case when not fragment

* - move decorateArea function to utils
- load config for changeBgMarquee use-case

* bug #2 and adobecom#4 fix

* MWPW-139604-Implement RTL design for selector tray and enticement (adobecom#150)

* Update firefly-interactive.css

* Update interactive-elements.css

* Update firefly-interactive.css

* delete all query params before setting new

* interactive marquee structure

* MWPW-140993 - [CC] update query-index path for merch-cards

* MWPW-140715-Add new locales in config (adobecom#153)

* Update scripts.js

* Update locale ietf as per https://github.com/adobecom/milo/pull/1708/files

* updating changes required only for MWPW-140715

* Update scripts.js

* Update scripts.js

---------

Co-authored-by: Ruchika Sinha <[email protected]>

* Remove out of scope geos from sitemap for batch 1C ROW (adobecom#156)

* Update helix-query.yaml

* Update helix-sitemap.yaml

* Authorfeedback for interactive marquee (adobecom#119)

* authoring feedback

* authoring feedback

* authoring feedback

* authoring feedback

* chnages in authoring feedback

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* lint issues

---------

Co-authored-by: Suhani Jain <[email protected]>
Co-authored-by: Suhani Jain <[email protected]>

* hreflang fix (adobecom#158)

* Adding Codeowners file to CC repo (adobecom#159)

Adding Codeowners file to CC repo

Test URLs:

Before: https://main--cc--adobecom.hlx.live/?martech=off
After: https://codeownersfile--cc--aishwaryamathuria.hlx.live/?martech=off

* run-nala.yaml

* update new line

* update nw line

* rm nw line

* rm n line

* script and utils chnages (adobecom#160)

Co-authored-by: Suhani Jain <[email protected]>

* MWPW-132393 Catalog page (adobecom#161)

* MWPW-136872 first draft for filter blocks (adobecom#107)
- using sidenav web component dep,
- using separate spectrum dep,
- introducing unit tests in CC
* MWPW_137257 sidenav block  (adobecom#118)
* MWPW-136866: index path config (adobecom#121)
for merch-cards block in Milo
* MWPW-132393: catalog layout
* update sidenav merch-cards integration
* update styles
* cleanup styles
* MWPW-137257 sidenav fixes (adobecom#122)

---------

Co-authored-by: ilyas Stéphane Türkben <[email protected]>

* MWPW-134233: sidenav deeplink fix (adobecom#126)

* MWPW-134233: sidenav deeplink fix

* MWPW-134233: sidenav deeplink fix

* MWPW-137257 adapt values to taxonomy (adobecom#141)

- possibility to explicitally set order / and item, by adding list with last token of taxonomy,
- types to be displayed if navigation is multilevel,
- search text now based on first bold text

* MWPW-139915: catalog load swc from Milo (adobecom#149)

* MWPW-141104: Consume Milo SWC in the unit tests (adobecom#157)

* review comments

* gh action review comments

* re-set logs, with lana this time

* remove sidenav

---------

Co-authored-by: ilyas Stéphane Türkben <[email protected]>
Co-authored-by: Ilyas Stéphane Türkben <[email protected]>

* MWPW-137257 make type title configurable (adobecom#163)

also types presence does manage types display

* authoring feedback changes

* Delete web-test-runner-config.mjs (adobecom#164)

* Update sitemap-index.xml to add new geos for 1C ROW (adobecom#166)

* Update scripts.js (adobecom#169)

* MWPW-136892: update prod domains (adobecom#171)

* recommendation of virtual comments added (adobecom#152)

Co-authored-by: Drashti Modasara <[email protected]>

* Readme update (adobecom#168)

* Update README.md

* Update README.md

* [main]MWPW-140914-Redirect user directly to firefly product page from firefly marketing page (adobecom#174)

* Update firefly-interactive.js

* remove redirect for firefly product page on page load for signed in user

* Redirect signed in user to firefly product page

* MWPW-141962-Fix interactive marquee css issues (adobecom#172)

* Update milo-marquee.css

* Update milo-marquee.css

* Update firefly-interactive.css

* Update firefly-interactive.css

* [Main]MWPW-142331-Batch1B ROW Sitemap (adobecom#178)

* MWPW-141042 card indexes for ROW (adobecom#175)

* batch 1B-ROW

* 1B ROW

* Update helix-query.yaml

* Update helix-sitemap.yaml

* fix typo

---------

Co-authored-by: Nicolas Peltier <[email protected]>

* Update scripts.js (adobecom#180)

* MWPW-142331-Remove duplicate entry (adobecom#182) (adobecom#183)

* Update helix-query.yaml

* Update helix-sitemap.yaml

* MWPW-143055-fix sitemap issues for batch 1B ROW (adobecom#189)

* fix sitemap issues

* Update helix-sitemap.yaml

---------

Co-authored-by: Ruchika Sinha <[email protected]>

* update index file (adobecom#190)

Co-authored-by: Ruchika Sinha <[email protected]>

* Sync main with stage (adobecom#198)

* universal promo terms 1st commit

* Added API failure case handler

* Remove console.log and updated the failure case.

* nit: typo

* Setting default api_key

* nit: TODO

* icon / other original content support, css to hide header/footer completely.

* poc reviewd

* api key updated

* nit: eslint update

* nit: eslint update

* nit: eslint update

* nit: eslint update

* nit: eslint update

* nit: eslint update

* test added

* added test

* MWPW-142280 Firefly single feature marquee (adobecom#191)

* firefly single feature

* fix lint issue

* fix blinking cursor issue on mobile and tablet

* optimize

---------

Co-authored-by: Ruchika Sinha <[email protected]>

* MWPW-143215 [sidenav]  make re-ordering possible with camel case (adobecom#192)

* service_providers is now optional as api_key

* update test

* MWPW-143533-Handle css for 2 values in selector tray (adobecom#195)

* MWPW-143533

* fix issues

---------

Co-authored-by: Ruchika Sinha <[email protected]>

* [Universal promo terms] update env logic (adobecom#197)

* stage condition added for env

* check prod URL instead

---------

Co-authored-by: Sean Choi <[email protected]>
Co-authored-by: Ruchika Sinha <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>

* add cis_ru (adobecom#200)

* Update scripts.js (adobecom#206)

* add cis sitemaps (adobecom#205)

* [Main] add Products to sitemap index (adobecom#217)

* add products to indes

* add sitemaps live links

* Sync main from stage for final stage rebase (adobecom#218)

Sync main from stage for final stage rebase
Merging following PRs -
adobecom#211
adobecom#212

* Merge pull request adobecom#229 from aishwaryamathuria/codecov

MWPW-144525 | Fixing the code coverage plugin path

* MWPW 144479 | Improve performance and reduce CLS for interactive marquee (adobecom#225)

Improve performance and reduce CLS for interactive marquee
Resolves: MWPW-144479

Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/ruchika/3a/firefly?martech=off
After: https://mwpw-144479--cc--aishwaryamathuria.hlx.live/drafts/ruchika/3a/firefly?martech=off

* merge from main

* Sync main with stage (adobecom#234)

* Update helix-query.yaml (adobecom#231)

* MWPW-143057-Remove mt and cy_en from CC sitemap (adobecom#223)

* Update sitemap-index.xml

* Update helix-query.yaml

* Update helix-sitemap.yaml

* Update firefly-interactive.css (adobecom#222)

* Update CODEOWNERS

* Update README.md

* Update README.md

* MWPW-145307- Move enticement text to p tag (adobecom#250)

* remove h2 for enticement text

* remove h2 for enticement text

* [MWPW-143093]-[Interactive Marquee - Media] Rename media classname to avoid collisions (adobecom#219)

* Update scripts.js

* Update universal-promo-terms.js (adobecom#211)

* add cis sitemaps (adobecom#205)

* [Stage] add products to index (adobecom#216)

* add products to index

* add sitemaps live links

* media to asset

* media to asset

* Update helix-query.yaml - fix line break

---------

Co-authored-by: Aishwarya Mathuria <[email protected]>
Co-authored-by: sharath-kannan <[email protected]>
Co-authored-by: Mariia Lukianets <[email protected]>
Co-authored-by: Drashti Modasara <[email protected]>

* @releng better hlxignore

- remove root json,
- remove code coverage,
- generic rule for sidekick like nested json

* Load media from cc-shared for root

* Create Kodiak config.yaml (adobecom#244)

* Create Kodiak config.yaml

Create Kodiak auto-ticketing config for MWPW-143712 and MWPW-143708

* Add watchers and assign to sumanh instead

Also edit the "team" field per Jed's troubleshooting with Javelin.

* Update config.json (adobecom#258)

Adding bulk publishing to tools dropdown.

* Update pull_request_template.md

* Fixed RTL positioning of enticement on genfill int-marquee (adobecom#257)

Fixed the enticement position in genfill interactive marquees for RTL locale in page and fragment.
Resolves: MWPW-145840

Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/drashti/bugs/genfill/document
After: https://genfill-stage--cc--adobecom.hlx.live/drafts/drashti/bugs/genfill/document

* MWPW-142971 | Interactive web components over Marquee and Aside (adobecom#251)

Interactive web components over Marquee and Aside
Requirement, Architecture and Demo Wiki: https://wiki.corp.adobe.com/pages/viewpage.action?pageId=3127606992

Resolves:
[MWPW-142971](https://jira.corp.adobe.com/browse/MWPW-142971) Ps Interactive Marquee + Aside
[MWPW-142980](https://jira.corp.adobe.com/browse/MWPW-142980) GenFill Marquee + Aside Interactive PS pages
[MWPW-142976](https://jira.corp.adobe.com/browse/MWPW-142976) Slider (Hue Sat) Interactive Marquee + Aside

Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/mathuria/interactiveelems/interactive-workflow4?martech=off
After: https://interactivity--cc--adobecom.hlx.live/drafts/mathuria/interactiveelems/interactive-workflow4?martech=off

* MWPW-146221 | Improving performance for hue sat (adobecom#261)

* Improving performance for hue sat

Resolves: MWPW-146221

Test URLs:
Before: https://main--cc--adobecom.hlx.live/drafts/mathuria/interactiveelems/demo/huesat/hue-sat-marquee1?martech=off
After: https://mwpw-146221--cc--aishwaryamathuria.hlx.live/drafts/mathuria/interactiveelems/demo/huesat/hue-sat-marquee1?martech=off

* MWPW-146229 | Integrating review comments and new workflows (adobecom#264)

Change heading-top to mobile-heading-top
Change generate-right to generate-side
Change the bullet list in selector tray to numbered list
Change the ordering of the list content with thumbnail first and display image next.
Adding new workflows
workflow-generate-select-generate
Generate -> Selector Tray -> Generate -> Crop -> Start Over
workflow-generate-selector
Generate -> Selector Tray -> Generate -> Start over
workflow-generate-triple-selector
Generate -> Selector Tray -> Generate -> Selector Tray -> Generate -> Selector Tray -> Start over

* MWPW-142006 - Enable repo-sync for graybox (adobecom#263)

Enable CC repo-sync for CC graybox repo
Resolves: MWPW-142006

* MWPW-143951: Optimize sidenav (adobecom#246)

move merch-card-collection and sidenav inside
catalog block.

includes: https://git.corp.adobe.com/wcms/tacocat.js/pull/552/files

depends on: adobecom/milo#2057

Resolves: MWPW-143951

Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/ilyas/catalog-sidenav?martech=off&georouting=off
After: https://mwpw-143951--cc--yesil.hlx.live/drafts/ilyas/catalog?martech=off&georouting=off

* [hue saturation] upload image icon authored is not seen visible in mobile mode (adobecom#265)

[hue saturation] upload image icon authored is not seen visible in mobile mode

Resolves: MWPW-146219

Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/suhjain/document7?martech=off
After: https://mwpw-146219--cc--adobecom.hlx.live/drafts/suhjain/document7?martech=off

* MWPW-144519 | Increasing unit test coverage (adobecom#269)

Increasing unit test coverage to be > 90

* MWPW-142972 | Integrating review comments (adobecom#267)

Integrating review comments for delay authoring of Start over button. 0-99 will be considered as sec and 99+ will be ms

* MWPW-147649 | Resync stage and main, reopening stage PRs (adobecom#287)

Reopening following PRs:
MWPW-143894, MWPW-142148 sidenav authoring enhancements adobecom#254
MWPW-145612 | CTA's of interactive marquee moved above the fold. adobecom#276
MWPW-142971 | Add new workflow for generate->select->startover adobecom#281
MWPW-147501 | Changing CSS for blue focus line to cover the whole div adobecom#283
MWPW-146794 | Avoid CLS due to image adobecom#284
MWPW-147361-Update firefly model to v3 adobecom#285
Resolves: MWPW-147649

* MWPW-142989-Multi image marquee (adobecom#280)

* MWPW-143894 moving category authoring to separate row

* MWPW-143894 more robust for edge cases

* draft

* simplification

* other fixes not brought in

* adding remnant stuff from MWPW-142148

* MWPW-143894 fix parent id

* changed order of interactive marquee for Mweb users

* fixed linting errors

* code enhancement

* spacing and padding adjustents for firefly marquee

* multi image firefly marquee

* css update

* handle responsive design for tablet

* MWPW-143904-New block: cc-mobile-app-banner (adobecom#271)

* app banner in cc

* app banner in CC

* add review comments

* code enhancement

wq
!
!

* Revert "MWPW-143904-New block: cc-mobile-app-banner (adobecom#271)"

This reverts commit 6c5a816.

* code enhancement

* DOTCOM-118347

* optimize css

* fix placeholder italic

* add unit tests

* tokenized the feature requested

* handle touch device

* MWPW-143894 some fixes

* wip

* wip

* Revert "DOTCOM-118347"

* add unit tests

* wip

* wip

* blinking cursor

* pull mweb changes

* increase aytocycle time

* Update milo-marquee.css

* Update firefly-masonry.css

* Optimize

* unit test

* optimize

* remove unnecessary code

* fix css

* support dark masonry promptbar

* css update

* fix intermittent CLS issue

* fix duplicate id issue for accessibility

* fix unit test

* change background img to img for SEO reasons

* incorporate review comments

* fix analytics for touch device

* css

* lint issue

* button css fix

* css fixes

* css fix

* css fix

* css fix

* css fix

* css fix

* fix foreground width

* css fix

* css fix

* remove unnecessary code

* Update firefly-masonry.css

* fix rtl

* optimize

* remove importing interactive-elements.css

* css fix

* fix table responsiveness

* fix MWPW-147643

* Update firefly-masonry.js

* Update firefly-masonry.js

* incorporate review comments

* review comments

* lint issue

* lint issue

* css fix

* set box sizing to fix isue when caas on page

* set box sizing to fix isue when caas on page

---------

Co-authored-by: Nicolas Peltier <[email protected]>
Co-authored-by: sharath kannan <[email protected]>
Co-authored-by: sharathkannan <[email protected]>
Co-authored-by: Aishwarya Mathuria <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>
Co-authored-by: Saloni Jain <[email protected]>

* MWPW-146221 | LCP is seen high on huesat (adobecom#282)

High LCP was seen for hue-sat marquee.
Resolves: MWPW-146221

* MWPW-147905-Move image span value outside of alt value (adobecom#290)

* Update firefly-masonry.js

* Update firefly-masonry.js

* fix lint issues

* Update firefly-masonry.js

* Update firefly-masonry.js

* incorporate review comments

* Continue to Photoshop button added on Hue-Sat marquee. (adobecom#291)

Functionality of continue to photoshop added on Hue-Sat marquee.

Resolves: MWPW-142976

Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/suhjain/interactive-marquee/continuetops
After: https://openinps--cc--adobecom.hlx.live/drafts/suhjain/interactive-marquee/continuetops

* Update firefly-masonry.js (adobecom#293)

* change dev env to stage (adobecom#294)

Continue to photoshop button is not seen working in stage ,proxy denied error is seen. Thus changed the dev env to stage.
Resolves: MWPW-148165

* 'Upload an image' button alignment is not proper for hue sat after localization

* Update interactive-metadata.js

* Update slider-tray.css

* Update slider-tray.css

* [MWPW-147521] interactive marquee container is not seen displayed as expected with resize flow (adobecom#301)

Fixes the foreground container width of the interactive marquee so that the text does not touch the edge of the screen on lower desktop screen sizes
Also fixes the generate prompt for firefly interactive marquee, which was going out of the image for screen size > 1200px and < 1300px.
Resolves: MWPW-147521

* Update slider-tray.css

* MWPW-148223 & MWPW-148222 | Kodiak vulnerable package due to different versions of same package. (adobecom#302)

This fix should resolve both these issues (MWPW-148223 & MWPW-148222).
Moved the package to dev dependency since it is not used by the application at runtime.
Resolves: MWPW-148223
Resolves: MWPW-148222

* feat(ci): added slack communication

* for initial trigger

* for initial trigger

* acomsis cookie logic for cn homepage

* branch changed to test branch

* MWPW-151642: Repo Sync Workflow for FG

* remove typo

* MWPW-151448 | Fixing dot media issue in locale (adobecom#312)

Adding dotmedia replacement for locale pages of root
Resolves: MWPW-151448

Test URLs:
Before: https://main--cc--adobecom.hlx.live/downloads/?martech=off
After: https://replacemedialocale--cc--adobecom.hlx.live/downloads?martech=off

https://www.stage.adobe.com/uk/downloads.html - To be verified after merge

* MWPW-148028 | Change bg remove launch load in deps js (adobecom#317)

Change bg remove launch load in deps js

Resolves: MWPW-148028

Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/mathuria/performance/remove-background?martech=off
After: https://mwpw148028--cc--adobecom.hlx.live/drafts/mathuria/performance/remove-background?martech=off

* fix: target branch to main

* fix: new line replace

* move acomsisCookieHandler into utils.js

* remove the parameter

* Various catalog related fixes (adobecom#307)

Add your specific features or fixes
Resolves:
MWPW-147697
MWPW-147762
MWPW-147772
MWPW-147850
MWPW-151163

Test URLs:

Before: https://main--cc--adobecom.hlx.live/products/catalog/?martech=off&georouting=off
After: https://catalog-fixes--cc--adobecom.hlx.live/products/catalog?martech=off&georouting=off

* Update scripts.js (adobecom#334)

Co-authored-by: Saloni Jain <[email protected]>

* MWPW-151792 | Fixing infinity reload bug (adobecom#337)

Resolves: MWPW-151792

Test URLs:

Before: https://stage--cc--adobecom.hlx.live/careers?martech=off
After: https://acomsis-cookie--cc--adobecom.hlx.live/careers?martech=off
This is the follow up PR for adobecom#321
This is for fixing bug after testing the logic stage.adobe.com

* MWPW-151792 | Acomsis cookie (adobecom#339)

Found a typo that creates a bug from adobecom#337

Resolves: MWPW-151792

Test URLs:

Before: https://stage--cc--adobecom.hlx.live/careers?martech=off
After: https://acomsis-cookie--cc--adobecom.hlx.live/careers?martech=off

* Update helix-query.yaml (adobecom#341)

* MWPW-153428-Eager load marquee background image only for current breakpoint (adobecom#346)

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* fix lint issue

* Update utils.js

* Update utils.js

* fix lint issue

* Update utils.js

* handle single background image

* Update utils.js

* Update utils.js

* incorporate review comments

* MWPW-148256 decorate catalog cards & some sidenav with analytics attributes (adobecom#343)

* MWPW-148256 decorate catalog page

* MWPW-148256 sort

* MWPW-148256 removing unit tests

to be moved later under functional tests eventually (unit test are really not trivial to setup)

* remove irregular whitespace

* MWPW-148256 attempt to proxy event

* MWPW-148256 defer to other tickets

* MWPW-148256 small update

---------

Co-authored-by: Saloni Jain <[email protected]>

* MWPW-153144 Pre-load Marquee image if the marquee is getting replaced in MEP (adobecom#345)

Pre-load Marquee image if the marquee is getting replaced in MEP

Resolves: MWPW-153144

Test URLs:

Before: https://main--cc--adobecom.hlx.page/drafts/suhjain/personalization/document
After: https://eagerloadimg--cc--adobecom.hlx.live/drafts/suhjain/personalization/document?mep=off&martech=off

* Add path finder tool to sidekick. (adobecom#331)

Add path finder tool to sidekick.

Adding path finder tool to sidekick.
Test URLs:

Before: https://main--cc--adobecom.hlx.live/careers?martech=off
After: https://rgclayton-path-finder--cc--adobecom.hlx.live/careers?martech=off
Added to Milo this week.

Access from any Word/Excel page.
Open sidekick
Click "path" button in sidekick (top level).
Launches the path tool.
Lists the relative (human readable) path for the Word/Excel doc.
Can modify the path to jump to a new Word/Excel doc.
Options include opening the path in same page or in a new tab

* fix(MWPW-152365):reading width increased. (adobecom#347)

* reading width increased

* Update styles.css

---------

Co-authored-by: Saloni Jain <[email protected]>

* Update utils.js (adobecom#350)

Co-authored-by: Saloni Jain <[email protected]>
Co-authored-by: Aishwarya Mathuria <[email protected]>

* MWPW-140115 Release notes on slack channel when PR merged with Main branch (adobecom#348)

* feat(title-map): pr link mapped with title

* fix: package-lock.json added

---------

Co-authored-by: Saloni Jain <[email protected]>

* add initial implementation with file read

* change approach to table api

* working state for reindex

* cleanup

* switch to dot env file

---------

Co-authored-by: Sunil Kamat <[email protected]>
Co-authored-by: mathuria <[email protected]>
Co-authored-by: Suhani Jain <[email protected]>
Co-authored-by: Suhani Jain <[email protected]>
Co-authored-by: Ruchika Sinha <[email protected]>
Co-authored-by: Ruchika Sinha <[email protected]>
Co-authored-by: Drashti Modasara <[email protected]>
Co-authored-by: Saloni Jain <[email protected]>
Co-authored-by: Suhani Jain <[email protected]>
Co-authored-by: Drashti Modasara <[email protected]>
Co-authored-by: Drashti Modasara <[email protected]>
Co-authored-by: Honwai Wong <[email protected]>
Co-authored-by: Drashti Modasara <[email protected]>
Co-authored-by: Honwai Wong <[email protected]>
Co-authored-by: nateekar <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>
Co-authored-by: ilyas Stéphane Türkben <[email protected]>
Co-authored-by: Ilyas Stéphane Türkben <[email protected]>
Co-authored-by: sharg1 <[email protected]>
Co-authored-by: Sean Choi <[email protected]>
Co-authored-by: sharath-kannan <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>
Co-authored-by: J. Casalino <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Arshad Mohammed <[email protected]>
Co-authored-by: sharath kannan <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: sivasadobe <[email protected]>
Co-authored-by: sukamat <[email protected]>
Co-authored-by: Siva S <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukamat sukamat sukamat approved these changes

@Ruchika4 Ruchika4 Ruchika4 approved these changes

@aishwaryamathuria aishwaryamathuria aishwaryamathuria approved these changes

Assignees
No one assigned
Labels
ready for main PR is ready to be merged to main branch ready for stage verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arshadparwaiz @salonijain3 @sukamat @aishwaryamathuria @Ruchika4