-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MWPW-150610): implement partial load with background fetch #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanrai
requested review from
cmiqueo,
jedjedjedM,
sheridansunier,
gmirijan and
shkhan91
October 4, 2024 21:20
cmiqueo
reviewed
Oct 7, 2024
sheridansunier
approved these changes
Oct 7, 2024
cmiqueo
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this PR include the build (dist/*) files?
@cmiqueo thanks for catching two mistakes!
|
This commit introduces a performance optimization for large card collections, specifically targeting collections with up to 4000 cards. It implements a new `partialLoadCount` feature to improve initial page load times and user experience. The main changes include: - Add new configuration options for partial load with background fetch - Implement two-phase loading strategy in the Container component - Update card count state management - Adjust pagination and load more functionality to work with total card count
sheridansunier
approved these changes
Nov 6, 2024
cmiqueo
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance Optimization for Large Card Collections
Problem
Large card collections (up to 4000 cards) were causing slow initial page load times and poor user experience.
Solution
This PR implements a two-phase loading strategy:
Changes
Added new configuration options in
index.html
:partialLoadWithBackgroundFetch.enabled
partialLoadWithBackgroundFetch.partialLoadCount
Updated
Container.jsx
to implement the new loading strategy:getCards
function to support partial loadingAdjusted various component props to use
cardCount
instead ofgridCards.length
How to Test
partialLoadWithBackgroundFetch
in the configurationpartialLoadCount
to a smaller number (e.g., 100)Notes
partialLoadCount
is configurable to allow fine-tuning based on specific use cases