Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MWPW-159159): Updates overlay links aria-label value #180

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

cmiqueo
Copy link
Collaborator

@cmiqueo cmiqueo commented Sep 27, 2024

Description:
This PR replaces the aria-label value for the overlay links so that instead of the link URL string it will display the card title.

Resolves:
https://jira.corp.adobe.com/browse/MWPW-159159

Before:

<a href="https://www.adobe.com/creativecloud/photography/discover/pet-photography.html" 
   target="_self" 
   rel="noopener noreferrer" 
   aria-label="https://www.adobe.com/creativecloud/photography/discover/pet-photography.html" 
   tabindex="0" 
   class="consonant-LinkBlocker"
></a>

After:

<a href="https://www.adobe.com/creativecloud/photography/discover/pet-photography.html" 
   target="_self" 
   rel="noopener noreferrer" 
   aria-label="Learn the best dog & cat photography tips" 
   tabindex="0" 
   class="consonant-LinkBlocker"
></a>

Copy link
Collaborator

@sanrai sanrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format should be fix(MWPW-159159): Updates overlay links aria-label for PR title and git commit message.

Please git commit amend to fix

@cmiqueo cmiqueo changed the title MWPW-159159(fix): Updates overlay links aria-label value fix(MWPW-159159): Updates overlay links aria-label value Sep 30, 2024
@cmiqueo
Copy link
Collaborator Author

cmiqueo commented Sep 30, 2024

format should be fix(MWPW-159159): Updates overlay links aria-label for PR title and git commit message.

Please git commit amend to fix

Good catch! :)

@cmiqueo cmiqueo requested a review from sanrai September 30, 2024 16:52
@cmiqueo cmiqueo merged commit ab88da5 into main Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants