MWPW-145727: add ability to have secondary cta used during live events #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheridansunier
temporarily deployed
to
github-pages
GitHub Actions
Inactive
sheridansunier
requested review from
sanrai and
cmiqueo
and removed request for
sanrai
sanrai
approved these changes
Aug 26, 2024
sheridansunier
force-pushed
the
MWPW-145727
branch
from
cffbe14
to
d533470
Compare
sheridansunier
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a Virtual Events Product Manager, I want to have a way for a different destination (e.g anchor link) and CTA copy when an event card is live so that when we use event cards to promote the upcoming homepage schedule, a click to the card will take the user to the specific destination (specifically to the marquee video player on the homepage).
This change requires:
To test this, you need a card that has a a secondaryCTA authored, and you need it to be an event that you can use servertime to observe the cards behavior before/during/after the card goes live. For my personal testing I was using this card collection: here it is! . But this does not show the actual feature working e2e b/c I mocked the secondaryCTA in my personal development.
You need to check that altCTA is used from milo. Be using the chimera-feature (or dev if it has merged but if it hasn't the most up to date code is on chimera-feature) and then you should be able to see that the CTA changes to the secondaryCTA when a card is live.