[Release] Stage to Main #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meganthecoder
commented
Dec 12, 2024
meganthecoder
commented
- MWPW-160548: CTA Widget and Chat CTA style updates #273
- MWPW-162887: Adding graybox to stageDomainMap #271
MWPW-162887: Adding graybox to stageDomainMap
* Updated CSS to match current designs. Found a few issues that require discusssion * Small tweaks to height and display: * Adding new block, good way there * Styles mostly all there, just need to get the 'modal' screen on mobile * add curtain * widget button style updates * sync with figma styles * unit tests * fix mobile landscape * change selector - safari 16 bug * fix button color on safari * hide scrollbar when not needed --------- Co-authored-by: Jason Slavin <[email protected]>
meganthecoder
requested review from
JasonHowellSlavin and
Brandon32
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 96.70% 96.80% +0.10%
==========================================
Files 12 13 +1
Lines 1336 1379 +43
==========================================
+ Hits 1292 1335 +43
Misses 44 44 ☔ View full report in Codecov by Sentry. |
Brandon32
approved these changes
Dec 12, 2024
JasonHowellSlavin
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.