Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate BACOM to Helix 5 #272

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Migrate BACOM to Helix 5 #272

merged 3 commits into from
Feb 12, 2025

Conversation

overmyheadandbody
Copy link
Contributor

@overmyheadandbody overmyheadandbody commented Dec 10, 2024

Description

Upgrading to .aem. from .hlx. as per the product requirements and docs.
This is not meant to be a complete PR, just one that starts you off. This should be carefully tested.

Resolves: MWPW-166673

Todo

  1. QA, QA, QA
  2. Merge
  3. Swap origin on the akamai level to consume aem.page and aem.live
  4. Once origins are switched, remove references to hlx.live or hlx.page from the codebase

Test URLs

All variations should continue working: (hlx|aem).(page|live)

Before: https://main--bacom--adobecom.hlx.page/
After: https://hlx5--bacom--adobecom.hlx.page/
Before: https://stage--bacom--adobecom.hlx.page/ch_de/products/real-time-customer-data-platform/rtcdp
After: https://hlx5--bacom--adobecom.hlx.page/ch_de/products/real-time-customer-data-platform/rtcdp

Before: https://main--bacom--adobecom.aem.page/ (not working, code from this branch is needed)
After: https://hlx5--bacom--adobecom.aem.page/
Before: https://stage--bacom--adobecom.aem.page/ch_de/products/real-time-customer-data-platform/rtcdp (not working, code from this branch is needed)
After: https://hlx5--bacom--adobecom.aem.page/ch_de/products/real-time-customer-data-platform/rtcdp

Before: https://main--bacom--adobecom.hlx.live/
After: https://hlx5--bacom--adobecom.hlx.live/
Before: https://stage--bacom--adobecom.hlx.live/ch_de/products/real-time-customer-data-platform/rtcdp
After: https://hlx5--bacom--adobecom.hlx.live/ch_de/products/real-time-customer-data-platform/rtcdp

Before: https://main--bacom--adobecom.aem.live/ (not working, code from this branch is needed)
After: https://hlx5--bacom--adobecom.aem.live/
Before: https://stage--bacom--adobecom.aem.live/ch_de/products/real-time-customer-data-platform/rtcdp (not working, code from this branch is needed)
After: https://hlx5--bacom--adobecom.aem.live/ch_de/products/real-time-customer-data-platform/rtcdp

Known issues

Copy link

aem-code-sync bot commented Dec 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Dec 10, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /ch_de/products/real-time-customer-data-platform/rtcdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /ch_de/products/real-time-customer-data-platform/rtcdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 / Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ / Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
📱 /ch_de/products/real-time-customer-data-platform/rtcdp Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ /ch_de/products/real-time-customer-data-platform/rtcdp Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /ch_de/products/real-time-customer-data-platform/rtcdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /ch_de/products/real-time-customer-data-platform/rtcdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /ch_de/products/real-time-customer-data-platform/rtcdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /ch_de/products/real-time-customer-data-platform/rtcdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (726bde3) to head (1b67826).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #272      +/-   ##
==========================================
- Coverage   96.80%   95.61%   -1.20%     
==========================================
  Files          13       13              
  Lines        1379     1392      +13     
==========================================
- Hits         1335     1331       -4     
- Misses         44       61      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dli3 Dli3 added verified it's been E2E tested by someone (that isn't the PR requestor) ready for stage labels Feb 12, 2025
@meganthecoder meganthecoder merged commit 077599c into stage Feb 12, 2025
8 of 9 checks passed
@meganthecoder meganthecoder deleted the hlx5 branch February 12, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for stage verified it's been E2E tested by someone (that isn't the PR requestor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants