-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-158446] Added stage domains map #248
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #248 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 11 11
Lines 1095 1096 +1
=======================================
+ Hits 1051 1052 +1
Misses 44 44 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this differentiate between business.adobe.com
and business.adobe.com/blog/
? Because they have different hlx urls
Hi @meganthecoder ! We might need a future enhancement to also handle this use-case. |
@robert-bogos This will cause issues with bacom blog links on hlx.page and hlx.live. For example:
This will take you to: https://mwpw-158446-domains-map--bacom--adobecom.hlx.live/blog/ which will 404 because the bacom blog is on |
@meganthecoder - I see this is a very particular use-case which hasn't been requested in the initial ticket. Is it possible to handle this as fast follow-up and unblock testing? |
The solution I see is to configure the current map to only convert links on business.stage.adobe.com and not on .hlx.live or .hlx.page. In this way testing is possible on stage and we won't have issues on .live and .page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits
This PR adds the
stageDomainsMap
, enabling the conversion of production URLs to their stage equivalents in the stage environment.More details about this feature can be found in this discussion.
Resolves: MWPW-158446
Test URLs: