Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-158446] Added stage domains map #248

Merged
merged 12 commits into from
Sep 23, 2024
Merged

Conversation

robert-bogos
Copy link
Contributor

@robert-bogos robert-bogos commented Sep 17, 2024

This PR adds the stageDomainsMap, enabling the conversion of production URLs to their stage equivalents in the stage environment.
More details about this feature can be found in this discussion.

Resolves: MWPW-158446

Test URLs:

Copy link

aem-code-sync bot commented Sep 17, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:33 Inactive
Copy link

aem-code-sync bot commented Sep 17, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (ea25c67) to head (30a83e4).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #248   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          11       11           
  Lines        1095     1096    +1     
=======================================
+ Hits         1051     1052    +1     
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:37 Inactive
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:37 Inactive
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:37 Inactive
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:37 Inactive
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:37 Inactive
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:39 Inactive
scripts/scripts.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:42 Inactive
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 17, 2024 15:44 Inactive
Copy link
Contributor

@meganthecoder meganthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this differentiate between business.adobe.com and business.adobe.com/blog/? Because they have different hlx urls

@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-158446-domains-map September 18, 2024 16:19 Inactive
@robert-bogos
Copy link
Contributor Author

Hi @meganthecoder !
No, it won’t differentiate between those because the difference lies in the URL path, not the domain. We’re only comparing domains using the map.

We might need a future enhancement to also handle this use-case.

@meganthecoder
Copy link
Contributor

Hi @meganthecoder ! No, it won’t differentiate between those because the difference lies in the URL path, not the domain. We’re only comparing domains using the map.

We might need a future enhancement to also handle this use-case.

@robert-bogos This will cause issues with bacom blog links on hlx.page and hlx.live. For example:

  1. Go to https://mwpw-158446-domains-map--bacom--adobecom.hlx.live/
  2. Click on "Resources" in the gnav
  3. Click on "Experience Cloud blog"

This will take you to: https://mwpw-158446-domains-map--bacom--adobecom.hlx.live/blog/ which will 404 because the bacom blog is on --bacom-blog--adobecom.hlx.live not --bacom--adobecom.hlx.live.

CC @narcis-radu @Dli3 @JasonHowellSlavin @Brandon32

@narcis-radu
Copy link

@meganthecoder - I see this is a very particular use-case which hasn't been requested in the initial ticket. Is it possible to handle this as fast follow-up and unblock testing?

@robert-bogos
Copy link
Contributor Author

The solution I see is to configure the current map to only convert links on business.stage.adobe.com and not on .hlx.live or .hlx.page. In this way testing is possible on stage and we won't have issues on .live and .page.
We can come with a future enhancement to handle those particular use-cases.
@narcis-radu @meganthecoder

Copy link
Contributor

@Brandon32 Brandon32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits

@meganthecoder meganthecoder merged commit 73bfd95 into stage Sep 23, 2024
7 checks passed
@meganthecoder meganthecoder deleted the MWPW-158446-domains-map branch September 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants