MWPW-158345 Decode CaaS Config #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon32
requested review from
JasonHowellSlavin and
meganthecoder
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #247 +/- ##
==========================================
+ Coverage 95.98% 96.70% +0.71%
==========================================
Files 11 12 +1
Lines 1096 1335 +239
==========================================
+ Hits 1052 1291 +239
Misses 44 44 ☔ View full report in Codecov by Sentry. |
blocks/url-decode/url-decode.js
Outdated
| /* c8 ignore next */ | ||
| const delay = (milliseconds) => new Promise((resolve) => { setTimeout(resolve, milliseconds); }); | ||
|
|
||
| export const loadQueryIndex = async (url) => { |
There was a problem hiding this comment.
Should see if anything like this exists in Milo as a util somewhere, if not you should definitely add it. Great way to batch and get the query index data.
There was a problem hiding this comment.
Article feed is the closest we have in Milo, I took this from bulk-updater.
meganthecoder
approved these changes
Sep 17, 2024
Brandon32
force-pushed
the
bmarshal/valid-caas
branch
from
6a6509d
to
b5fbb01
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Brandon32
force-pushed
the
bmarshal/valid-caas
branch
from
b5fbb01
to
f0c33db
Compare
Brandon32
force-pushed
the
bmarshal/valid-caas
branch
from
f0c33db
to
e5e433a
Compare
meganthecoder
approved these changes
Sep 18, 2024
Brandon32
force-pushed
the
bmarshal/valid-caas
branch
from
dee6751
to
fdcdba0
Compare
Brandon32
force-pushed
the
bmarshal/valid-caas
branch
from
136889a
to
82cdb85
Compare
Brandon32
force-pushed
the
bmarshal/valid-caas
branch
from
82cdb85
to
450aaa6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-158345
Test URLs: