MWPW-152082 Utils to Scripts #220
Conversation
Brandon32
requested review from
meganthecoder and
JasonHowellSlavin
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #220 +/- ##
==========================================
+ Coverage 95.43% 96.21% +0.77%
==========================================
Files 11 11
Lines 899 1082 +183
==========================================
+ Hits 858 1041 +183
Misses 41 41 ☔ View full report in Codecov by Sentry. |
| ['https://business.stage.adobe.com', 'https://main--milo--adobecom.hlx.live/libs'], | ||
| ['https://business.stage.adobe.com?milolibs=foo', 'https://foo--milo--adobecom.hlx.live/libs'], | ||
| ['https://business.stage.adobe.com?milolibs=awesome--milo--forkedowner', 'https://awesome--milo--forkedowner.hlx.live/libs'], | ||
| ['https://main--bacom--adobecom.hlx.page/', 'https://main--milo--adobecom.hlx.live/libs'], | ||
| ['https://main--bacom--adobecom.hlx.page/?milolibs=foo', 'https://foo--milo--adobecom.hlx.live/libs'], | ||
| ['https://main--bacom--adobecom.hlx.page/?milolibs=local', 'http://localhost:6456/libs'], | ||
| ['https://main--bacom--adobecom.hlx.page/?milolibs=awesome--milo--forkedowner', 'https://awesome--milo--forkedowner.hlx.live/libs'], | ||
| ['https://main--bacom--adobecom.hlx.live/', 'https://main--milo--adobecom.hlx.live/libs'], | ||
| ['https://main--bacom--adobecom.hlx.live/?milolibs=foo', 'https://foo--milo--adobecom.hlx.live/libs'], | ||
| ['https://main--bacom--adobecom.hlx.live/?milolibs=local', 'http://localhost:6456/libs'], | ||
| ['https://main--bacom--adobecom.hlx.live/?milolibs=awesome--milo--forkedowner', 'https://awesome--milo--forkedowner.hlx.live/libs'], | ||
| ['http://localhost:3000', 'https://main--milo--adobecom.hlx.live/libs'], | ||
| ['http://localhost:3000?milolibs=foo', 'https://foo--milo--adobecom.hlx.live/libs'], | ||
| ['http://localhost:3000?milolibs=local', 'http://localhost:6456/libs'], | ||
| ['http://localhost:3000?milolibs=awesome--milo--forkedowner', 'https://awesome--milo--forkedowner.hlx.live/libs'], |
There was a problem hiding this comment.
You could probably cut down the number of test cases here. We know that the code will proceed to set the branch variable based on the hostname containing .hlx, local, or .stage.. You could check each of those once, and then choose one to check that the branch functionality is working as expected.
There was a problem hiding this comment.
I wouldn't want to base the test on how the code is written and I want to make sure all of these cases are covered. This test is not fetching resources or doing anything expensive, we could add many more test cases if we so wanted and probably should for lower environments.
LIBSand remove test calls tosetLibsResolves: MWPW-152082
Test URLs:
Verification URLS for Consumer Blocks
https://bmarshal-utils-to-scripts--bacom--adobecom.hlx.page/docs/library/blocks/chat-cta
https://bmarshal-utils-to-scripts--bacom--adobecom.hlx.page/docs/library/blocks/comparison-table
https://bmarshal-utils-to-scripts--bacom--adobecom.hlx.page/docs/library/blocks/event-speakers
https://bmarshal-utils-to-scripts--bacom--adobecom.hlx.page/docs/library/blocks/stats
https://bmarshal-utils-to-scripts--bacom--adobecom.hlx.page/docs/library/blocks/tree-view
https://bmarshal-utils-to-scripts--bacom--adobecom.hlx.page/docs/library/blocks/workfront-login