-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-153603 Remove stage mapping #218
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #218 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 11 11
Lines 899 899
=======================================
Hits 858 858
Misses 41 41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I suppose we could have left some of the others in, but this is cleaner.
@Dli3 signed off via slack |
Resolves: MWPW-153603
Related: MWPW-153692
Test URLs:
CTA link:
Scroll down to "Grow leads without growing your marketing spend." => Read report.
Should link to: https://business.adobe.com/resources/reports/the-total-economic-impact-of-bizible.html
Not the stage link: https://business.stage.adobe.com/resources/reports/the-total-economic-impact-of-bizible.html
PDF Viewer:
PDF still won't load in the "after" page because the pdf viewer key doesn't work on feature branches, but you can see in the network tab that it's correctly getting the prod link: https://business.adobe.com/content/dam/dx/us/en/resources/sdk/how-to-achieve-personalization-at-scale-in-financial-services/how-to-achieve-personalization-at-scale-in-financial-services-v2.pdf