MWPW-143973: CLS Issue with Grid Width #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonHowellSlavin
requested review from
Brandon32 and
meganthecoder
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
meganthecoder
approved these changes
Mar 14, 2024
Brandon32
approved these changes
Mar 19, 2024
Dli3
added
the
verified
meganthecoder
added a commit
that referenced
this pull request
Mar 25, 2024
This reverts commit bfacc2d.
meganthecoder
added a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display: blockand resets two properties for the classes effected.Context:
Display block is overriding the styles that Milo implements to prevent CLS. However, due to previous issues that occur with the
grid-widthclasses, these styles were added to insure b.a.com pages did not break. There is a current PR to fix this in Milo, which would then necessitate us removing some of the code that was part of our hotfix.However, when attempting to remove some of the hotfix CSS it caused issues on other pages where the CLS issue was observed. Until the changes in Milo get verified and then merged, we may need to keep the hotfix code in place.
See these PRs:
Resolves: MWPW-143973
Test URLs:
Before: https://main--bacom--adobecom.hlx.live/drafts/cmillar/adobe-campaign
Before: https://main--bacom--adobecom.hlx.page/products/experience-manager/digital-commerce
Before: https://main--bacom--adobecom.hlx.live/resources/holiday-shopping-report
Before: https://main--bacom--adobecom.hlx.page/products/analytics/adobe-analytics-benefits
After: https://cls-fix--bacom--adobecom.hlx.live/drafts/cmillar/adobe-campaign
After: https://cls-fix--bacom--adobecom.hlx.page/products/experience-manager/digital-commerce
After: https://cls-fix--bacom--adobecom.hlx.live/resources/holiday-shopping-report
After: https://cls-fix--bacom--adobecom.hlx.live/products/analytics/adobe-analytics-benefits