MWPW-142290: Reverting Libs Stage Updates #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stage logic and tests as they are not needed
JasonHowellSlavin
requested review from
Brandon32 and
meganthecoder
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 95.62% 95.61% -0.01%
==========================================
Files 11 11
Lines 937 936 -1
==========================================
- Hits 896 895 -1
Misses 41 41 ☔ View full report in Codecov by Sentry. |
meganthecoder
approved these changes
Feb 20, 2024
Brandon32
reviewed
Feb 20, 2024
| @@ -25,24 +25,6 @@ describe('Libs', () => { | |||
| expect(libs).to.equal('https://foo--milo--adobecom.hlx.live/libs'); | |||
| }); | |||
|
|
|||
| it('Supports milo stage libs with stage as host', () => { | |||
There was a problem hiding this comment.
adding a it.skip with a comment might be useful here
There was a problem hiding this comment.
Do you mean to say to keep these tests and just skip for now or? I don't think they are needed, and the functionality that is expected already gets covered.
There was a problem hiding this comment.
Going to merge this, as the stage code in our set libs is more important to remove. I can add an issue to add test skips if you think that is pertinent @Brandon32.
Brandon32
approved these changes
Feb 20, 2024
JasonHowellSlavin
added a commit
that referenced
this pull request
Mar 12, 2024
* MWPW-138347 Update fonts * MWPW-138026 Add tags to lana logs * Add floodgate option to sidekick tools menu * MWPW-138026 Add tags to lana logs * Adding the fg sync workflow (#163) * MWPW-138379 Add publish date to all query indexes * MWPW-138379 Query index date format * Fix BACOM Homepage Marquee LCP When another block is placed above marquee (aside, etc.), that blocks image is selected as LCP when it should be marquee. This PR will prioritize marquee with a fallback to first document image if there is no marquee present. * No nested ifs * Remove else * MWPW-141206 AA University for Marketo (#167) * MWPW-139819 Redirect Formatter PoC (#166) * linter * Needs a lot of cleanup, but working as expected currently * Added some functionality, going to ask for Malik to look at it, and get some dev feedback, then continue * Adding functionality, styles, still need to add additional tests and error handling * Added tests, some cleanup and styles * Small cleanup items in prep for code review * CR changes * CR changes * Additional clariications for usability * Update blocks/redirects-formatter/redirects-formatter.js Co-authored-by: Megan Thomas <[email protected]> * CR changes * Update blocks/redirects-formatter/redirects-formatter.js Co-authored-by: Megan Thomas <[email protected]> --------- Co-authored-by: Megan Thomas <[email protected]> * MWPW-142098: Ignore pink sidekick config during sync * MWPW-141760: Add .html to Output of Redirect Tool (#169) * Adding .html to output if not present. Adding tests and modifying mocks for new functionality * Adding checks for /blog/ and non b.a.com urls * Cr comments * Update blocks/redirects-formatter/redirects-formatter.js Co-authored-by: Megan Thomas <[email protected]> * Cr --------- Co-authored-by: Megan Thomas <[email protected]> * MWPW-135751 faas loading * PR Changes * MWPW-142290: Update get/setLibs for stage (#172) * Updating getLibs to Milo College format, adding testing for libs * More tests, moving around vars * Remove commented out code * CR fixes * MWPW-142290: Reverting Libs Stage Updates (#175) * Updating our current libs patterns to match Milo College. Removing the stage logic and tests as they are not needed * test descriptor to match the rest * Update config.json (#177) --------- Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Chris Millar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-142290
Test URLs: