-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-135751 faas loading #171
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 11 11
Lines 943 943
=======================================
Hits 899 899
Misses 44 44 ☔ View full report in Codecov by Sentry. |
scripts/scripts.js
Outdated
const link = document.createElement('link'); | ||
link.setAttribute('rel', 'stylesheet'); | ||
link.setAttribute('href', '/styles/faas.css'); | ||
document.head.appendChild(link); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially a copy of
Lines 178 to 181 in e0b12f8
const link = document.createElement('link'); | |
link.setAttribute('rel', 'stylesheet'); | |
link.setAttribute('href', path); | |
document.head.appendChild(link); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I made a simplified loadStyle
.
Resolves: MWPW-135751
Test URLs: