Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-135751 faas loading #171

Merged
merged 2 commits into from
Feb 20, 2024
Merged

MWPW-135751 faas loading #171

merged 2 commits into from
Feb 20, 2024

Conversation

Copy link

aem-code-sync bot commented Feb 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 12, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1feafe4) 95.33% compared to head (e0b12f8) 95.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          11       11           
  Lines         943      943           
=======================================
  Hits          899      899           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 205 to 208
const link = document.createElement('link');
link.setAttribute('rel', 'stylesheet');
link.setAttribute('href', '/styles/faas.css');
document.head.appendChild(link);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is essentially a copy of

bacom/scripts/scripts.js

Lines 178 to 181 in e0b12f8

const link = document.createElement('link');
link.setAttribute('rel', 'stylesheet');
link.setAttribute('href', path);
document.head.appendChild(link);
, could we have a method that is used by both pieces of logic instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I made a simplified loadStyle.

@Dli3 Dli3 added the verified it's been E2E tested by someone (that isn't the PR requestor) label Feb 16, 2024
@Brandon32 Brandon32 merged commit 7ae46f5 into main Feb 20, 2024
9 checks passed
@Brandon32 Brandon32 deleted the bmarshal/faas-loading branch February 20, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified it's been E2E tested by someone (that isn't the PR requestor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants