[MWPW-134597] Bacom run-lint workflow #139

JasonHowellSlavin · 2023-08-03T21:08:05Z

Add the same workflow added by hparra in https://github.com/adobecom/milo/pull/988/files

https://mwpw-134597-run-lint-pr--bacom--adobecom.hlx.live?martech=off

aem-code-sync · 2023-08-03T21:08:07Z

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-run PSI Checks

codecov-commenter · 2023-08-03T21:10:19Z

Codecov Report

Merging #139 (7809936) into main (2ccfaff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   96.36%   96.37%           
=======================================
  Files           6        6           
  Lines         468      469    +1     
=======================================
+ Hits          451      452    +1     
  Misses         17       17

Files Changed	Coverage Δ
blocks/faas-decode/faas-decode.js	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hparra

See package-lock.json. Shouldn't we be installing from npm proper and not artifactory? Related?

Don't forget to copy over changes from .eslintrc.js

github-actions · 2023-08-04T19:18:37Z

blocks/faas-decode/faas-decode.js

@@ -6,6 +6,7 @@ export default async function init(el) {
  const resp = await fetch(url);


🚫 [eslint] <compat/compat> _{reported by reviewdog 🐶}
fetch is not supported in op_mini all

…o the same browsers as Milo

aem-code-sync · 2023-08-08T00:28:26Z

Page	Scores	Audits	Google
/		Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401)