You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two classes to styles.css as overrides for CaaS min-height in section metadata.
The small class represents roughly the height of the half cards, the medium the full sized cards.
Context
After doing some investigation, essentially loading the footer after CaaS cards load would require a change against the CaaS react components themselves, and may not be the best approach. The CaaS react component mounts to the DOM before the cards are finished fetching, and the CaaS component itself is controlled by the CaaS react components, meaning that though we could ask for an event to be added, there may occur situations in which the footer would not load. In addition to this, since the footer is loaded in loadArea() changes to prevent CLS on this page would require a change that could have effects on all milo consumers.
Because the issue was identified with resources/main on bacom, I am putting the overrides here instead of Milo, since we are not aware of who else may need them. Should it be determined styles like this are needed by the broader community, we can move them then.
Tested via pagespeed insights on a Milo branch first to ensure that CLS was 0, moved to bacom for this PR.
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.
Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401)
The reason will be displayed to describe this comment to others. Learn more.
I thought we'd be fixing this in milo, but I understand the decision to put it in bacom. We only have one use case so far, and it's possible that no other pages will need this. Given that, do we really want to include .caas-spacing-s if it's not being used?
I thought we'd be fixing this in milo, but I understand the decision to put it in bacom. We only have one use case so far, and it's possible that no other pages will need this. Given that, do we really want to include .caas-spacing-s if it's not being used?
I wrestled with both adding to milo and the additional class. It's not much process to add another class so we can remove the caas-spacing-s.
verifiedit's been E2E tested by someone (that isn't the PR requestor)
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dli3
added
the
verified
Context
After doing some investigation, essentially loading the footer after CaaS cards load would require a change against the CaaS react components themselves, and may not be the best approach. The CaaS react component mounts to the DOM before the cards are finished fetching, and the CaaS component itself is controlled by the CaaS react components, meaning that though we could ask for an event to be added, there may occur situations in which the footer would not load. In addition to this, since the footer is loaded in
loadArea()changes to prevent CLS on this page would require a change that could have effects on all milo consumers.Because the issue was identified with resources/main on bacom, I am putting the overrides here instead of Milo, since we are not aware of who else may need them. Should it be determined styles like this are needed by the broader community, we can move them then.
Tested via pagespeed insights on a Milo branch first to ensure that CLS was 0, moved to bacom for this PR.
Resolves: MWPW-133167
Test URLs: