Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #124

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Update PR template #124

merged 1 commit into from
Jun 23, 2023

Conversation

Brandon32
Copy link
Contributor

  • Update PR template to use published content to get lighthouse scores.

Resolves: #106

Test URLs:

@Brandon32 Brandon32 added the trivial PR doesn't require E2E testing by a reviewer label Jun 23, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Jun 23, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 23, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

Codecov Report

Merging #124 (2d8006c) into main (3bf4b2d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files           6        6           
  Lines         468      468           
=======================================
  Hits          451      451           
  Misses         17       17           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Brandon32 Brandon32 merged commit 34b71f4 into main Jun 23, 2023
@Brandon32 Brandon32 deleted the bmarshal/pr-template-live branch June 23, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Lighthouse scores check
4 participants