WIP: Adobe Students implementation #1
Annotations
10 errors and 3 warnings
Running eslint:
adobe-students/scripts/aem.js#L673
[eslint] reported by reviewdog 🐶
Unexpected line break after this opening brace.
Raw Output:
{"ruleId":"object-curly-newline","severity":2,"message":"Unexpected line break after this opening brace.","line":673,"column":8,"nodeType":"ExportNamedDeclaration","messageId":"unexpectedLinebreakAfterOpeningBrace","endLine":673,"endColumn":9,"fix":{"range":[20978,20981],"text":""}}
|
Running eslint:
adobe-students/scripts/aem.js#L698
[eslint] reported by reviewdog 🐶
Unexpected line break before this closing brace.
Raw Output:
{"ruleId":"object-curly-newline","severity":2,"message":"Unexpected line break before this closing brace.","line":698,"column":1,"nodeType":"ExportNamedDeclaration","messageId":"unexpectedLinebreakBeforeClosingBrace","endLine":698,"endColumn":2,"fix":{"range":[21379,21380],"text":""}}
|
Running eslint:
adobe-students/scripts/decorate.js#L21
[eslint] reported by reviewdog 🐶
Prefer default export.
Raw Output:
{"ruleId":"import/prefer-default-export","severity":2,"message":"Prefer default export.","line":21,"column":1,"nodeType":"ExportNamedDeclaration","endLine":25,"endColumn":2}
|
Running eslint:
adobe-students/scripts/goCart.js#L1
[eslint] reported by reviewdog 🐶
Prefer default export.
Raw Output:
{"ruleId":"import/prefer-default-export","severity":2,"message":"Prefer default export.","line":1,"column":1,"nodeType":"ExportNamedDeclaration","endLine":31,"endColumn":2}
|
Running eslint:
adobe-students/scripts/goCart.js#L8
[eslint] reported by reviewdog 🐶
Multiple spaces found before 'urlParams'.
Raw Output:
{"ruleId":"no-multi-spaces","severity":2,"message":"Multiple spaces found before 'urlParams'.","line":8,"column":22,"nodeType":"Identifier","messageId":"multipleSpaces","endLine":8,"endColumn":24,"fix":{"range":[312,314],"text":" "}}
|
Running eslint:
adobe-students/scripts/goCart.js#L12
[eslint] reported by reviewdog 🐶
iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.
Raw Output:
{"ruleId":"no-restricted-syntax","severity":2,"message":"iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.","line":12,"column":3,"nodeType":"ForOfStatement","messageId":"restrictedSyntax","endLine":14,"endColumn":4}
|
Running eslint:
adobe-students/scripts/goCart.js#L13
[eslint] reported by reviewdog 🐶
Unexpected string concatenation.
Raw Output:
{"ruleId":"prefer-template","severity":2,"message":"Unexpected string concatenation.","line":13,"column":19,"nodeType":"BinaryExpression","messageId":"unexpectedStringConcatenation","endLine":13,"endColumn":76,"fix":{"range":[538,595],"text":"`${encodeURIComponent(key) }=${ encodeURIComponent(value)}`"}}
|
Running eslint:
adobe-students/scripts/goCart.js#L19
[eslint] reported by reviewdog 🐶
Unexpected line break after this opening brace.
Raw Output:
{"ruleId":"object-curly-newline","severity":2,"message":"Unexpected line break after this opening brace.","line":19,"column":16,"nodeType":"ObjectExpression","messageId":"unexpectedLinebreakAfterOpeningBrace","endLine":19,"endColumn":17,"fix":{"range":[679,688],"text":""}}
|
Running eslint
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
Running eslint:
adobe-students/scripts/goCart.js#L21
[eslint] reported by reviewdog 🐶
Unexpected line break before this closing brace.
Raw Output:
{"ruleId":"object-curly-newline","severity":2,"message":"Unexpected line break before this closing brace.","line":21,"column":7,"nodeType":"ObjectExpression","messageId":"unexpectedLinebreakBeforeClosingBrace","endLine":21,"endColumn":8,"fix":{"range":[740,747],"text":""}}
|
Running eslint:
adobe-students/scripts/decorate.js#L17
[eslint] reported by reviewdog 🐶
Unexpected console statement.
Raw Output:
{"ruleId":"no-console","severity":1,"message":"Unexpected console statement.","line":17,"column":5,"nodeType":"MemberExpression","messageId":"unexpected","endLine":17,"endColumn":16}
|
Running eslint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Running eslint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v2, tj-actions/changed-files@v38. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|