-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MSE SDK with direct access to ACDL #19
base: elsie-base-design
Are you sure you want to change the base?
Conversation
Is this removing events for sensei? My understanding is that the MSE SDK is needed to send events to sensei. Is this possible through ACDL? ( I have a limited understanding here lol) |
@MichaelHeinzman MSE SDK is a wrapper around ACDL which introduces some overhead. ACDL itself is pending some improvements in this regard as well. For Edge Delivery storefronts in particular, we try to keep the implementation as lightweight as possible. From an eventing / Sensei perspective, this PR does not change or break any existing functionality. |
Oh okay thank you, I'll look into it more then. |
if (categorySearch) { | ||
magentoStorefrontEvtPublish?.categoryResultsView && | ||
magentoStorefrontEvtPublish.categoryResultsView(SEARCH_UNIT_ID); | ||
if (categorySearch && categoryId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@herzog31 Should this be an or condition instead? Everywhere else seems to have a fallback of category path first, then category id.
This is particularly an issue with Edge Delivery since the content is the same across all backend environments, and category IDs vary per environment. We would need to make an initial graphql call to get the category ID based on the category path and then initiate this widget
Description
categories
query to retrieve category information.categoryContext
required for product recommendations.currentCategoryId
.currentCategoryId
is provided, it will also be used as filter forproductSearch
.Motivation and Context
How Has This Been Tested?
See hlxsites/aem-boilerplate-commerce#11
Types of changes
Checklist: