Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action-button): prevent diacritic clipping in thai #4881

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(action-button): prevent diacritic clipping in thai #4881

wants to merge 1 commit into from

Conversation

rubencarvalho
Copy link
Collaborator

Description

Pulling the release from CSS, related to adobe/spectrum-css#3256

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this

  • Test case 2

    1. Go here
    2. Do this

  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@github-actions GitHub Actions
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11595695902

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.186%
Totals Coverage Status
Change from base Build 11595273482: 0.0%
Covered Lines: 32313
Relevant Lines: 32735
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Tachometer results

Chrome

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 53.60ms - 54.91ms - faster ✔
8% - 11%
4.53ms - 6.62ms
branch 715 kB 59.02ms - 60.64ms slower ❌
8% - 12%
4.53ms - 6.62ms		 -

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 565 kB 77.92ms - 79.48ms - faster ✔
9% - 11%
7.72ms - 10.10ms
branch 771 kB 86.71ms - 88.51ms slower ❌
10% - 13%
7.72ms - 10.10ms		 -

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 588 kB 49.13ms - 50.74ms - faster ✔
7% - 11%
3.96ms - 6.06ms
branch 793 kB 54.27ms - 55.62ms slower ❌
8% - 12%
3.96ms - 6.06ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 706 kB 144.74ms - 147.56ms - faster ✔
6% - 9%
9.47ms - 13.77ms
branch 917 kB 156.15ms - 159.40ms slower ❌
6% - 9%
9.47ms - 13.77ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 663 kB 69.62ms - 70.83ms - faster ✔
11% - 13%
8.82ms - 10.72ms
branch 874 kB 79.27ms - 80.72ms slower ❌
12% - 15%
8.82ms - 10.72ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 662 kB 68.36ms - 69.43ms - faster ✔
13% - 16%
10.59ms - 13.43ms
branch 873 kB 79.59ms - 82.22ms slower ❌
15% - 20%
10.59ms - 13.43ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 852 kB 1874.03ms - 1876.79ms - unsure 🔍
-0% - -0%
-7.52ms - -3.58ms
branch 1.05 MB 1879.56ms - 1882.36ms unsure 🔍
+0% - +0%
+3.58ms - +7.52ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 850 kB 1876.87ms - 1879.78ms - unsure 🔍
-0% - -0%
-8.70ms - -4.51ms
branch 1.05 MB 1883.42ms - 1886.44ms unsure 🔍
+0% - +0%
+4.51ms - +8.70ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 723 kB 510.38ms - 516.23ms - faster ✔
7% - 8%
35.88ms - 43.45ms
branch 936 kB 550.56ms - 555.36ms slower ❌
7% - 8%
35.88ms - 43.45ms		 -

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 518 kB 36.39ms - 37.10ms - faster ✔
10% - 13%
4.32ms - 5.47ms
branch 757 kB 41.19ms - 42.08ms slower ❌
12% - 15%
4.32ms - 5.47ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 766 kB 37.91ms - 38.53ms - faster ✔
14% - 16%
6.44ms - 7.30ms
branch 957 kB 44.79ms - 45.39ms slower ❌
17% - 19%
6.44ms - 7.30ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 766 kB 398.21ms - 404.42ms - faster ✔
6% - 8%
26.56ms - 35.70ms
branch 957 kB 429.09ms - 435.79ms slower ❌
7% - 9%
26.56ms - 35.70ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 694 kB 52.84ms - 53.98ms - faster ✔
11% - 14%
6.97ms - 8.73ms
branch 898 kB 60.59ms - 61.92ms slower ❌
13% - 16%
6.97ms - 8.73ms		 -

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 417 kB 13.68ms - 13.94ms - faster ✔
18% - 20%
3.10ms - 3.48ms
branch 638 kB 16.96ms - 17.24ms slower ❌
22% - 25%
3.10ms - 3.48ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 210.26ms - 216.43ms - faster ✔
5% - 11%
11.37ms - 26.09ms
branch 716 kB 225.40ms - 238.76ms slower ❌
5% - 12%
11.37ms - 26.09ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 745 kB 438.25ms - 444.75ms - faster ✔
1% - 3%
3.75ms - 11.48ms
branch 939 kB 447.02ms - 451.22ms slower ❌
1% - 3%
3.75ms - 11.48ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 827 kB 24.13ms - 24.92ms - faster ✔
14% - 18%
4.15ms - 5.18ms
branch 1.02 MB 28.86ms - 29.51ms slower ❌
17% - 21%
4.15ms - 5.18ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 358.26ms - 362.45ms - faster ✔
3% - 5%
11.99ms - 17.65ms
branch 1.01 MB 373.27ms - 377.08ms slower ❌
3% - 5%
11.99ms - 17.65ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 612 kB 43.00ms - 43.82ms - faster ✔
12% - 15%
5.82ms - 7.61ms
branch 805 kB 49.33ms - 50.92ms slower ❌
13% - 18%
5.82ms - 7.61ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 570 kB 523.23ms - 530.35ms - faster ✔
3% - 5%
16.61ms - 27.87ms
branch 774 kB 544.66ms - 553.39ms slower ❌
3% - 5%
16.61ms - 27.87ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 584 kB 104.98ms - 105.69ms - faster ✔
6% - 7%
6.99ms - 8.25ms
branch 774 kB 112.43ms - 113.48ms slower ❌
7% - 8%
6.99ms - 8.25ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 79.81ms - 81.16ms - faster ✔
7% - 10%
5.94ms - 8.50ms
branch 717 kB 86.62ms - 88.79ms slower ❌
7% - 11%
5.94ms - 8.50ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 623 kB 35.02ms - 35.71ms - faster ✔
10% - 12%
3.89ms - 4.83ms
branch 827 kB 39.40ms - 40.05ms slower ❌
11% - 14%
3.89ms - 4.83ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 584 kB 24.11ms - 24.66ms - faster ✔
17% - 19%
4.95ms - 5.79ms
branch 788 kB 29.44ms - 30.08ms slower ❌
20% - 24%
4.95ms - 5.79ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 54.35ms - 55.42ms - faster ✔
7% - 10%
4.48ms - 5.95ms
branch 911 kB 59.59ms - 60.61ms slower ❌
8% - 11%
4.48ms - 5.95ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 685 kB 43.53ms - 45.00ms - faster ✔
11% - 14%
5.40ms - 7.26ms
branch 886 kB 50.04ms - 51.15ms slower ❌
12% - 17%
5.40ms - 7.26ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 547 kB 59.43ms - 62.23ms - faster ✔
10% - 14%
6.53ms - 10.06ms
branch 761 kB 68.06ms - 70.20ms slower ❌
10% - 17%
6.53ms - 10.06ms		 -
Firefox

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 112.96ms - 119.20ms - faster ✔
4% - 11%
5.02ms - 13.98ms
branch 715 kB 122.37ms - 128.79ms slower ❌
4% - 12%
5.02ms - 13.98ms		 -

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 565 kB 157.52ms - 164.28ms - faster ✔
5% - 11%
9.30ms - 19.74ms
branch 771 kB 171.44ms - 179.40ms slower ❌
6% - 12%
9.30ms - 19.74ms		 -

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 588 kB 107.60ms - 113.04ms - faster ✔
5% - 12%
5.60ms - 14.56ms
branch 793 kB 116.84ms - 123.96ms slower ❌
5% - 13%
5.60ms - 14.56ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 706 kB 278.50ms - 281.90ms - faster ✔
12% - 13%
38.77ms - 43.39ms
branch 917 kB 319.71ms - 322.85ms slower ❌
14% - 16%
38.77ms - 43.39ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 663 kB 137.67ms - 140.25ms - faster ✔
3% - 5%
3.91ms - 6.85ms
branch 874 kB 143.64ms - 145.04ms slower ❌
3% - 5%
3.91ms - 6.85ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 662 kB 127.72ms - 130.72ms - faster ✔
8% - 11%
10.69ms - 15.27ms
branch 873 kB 140.47ms - 143.93ms slower ❌
8% - 12%
10.69ms - 15.27ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 852 kB 1882.20ms - 1889.04ms - faster ✔
1% - 1%
9.61ms - 18.07ms
branch 1.05 MB 1896.96ms - 1901.96ms slower ❌
1% - 1%
9.61ms - 18.07ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 850 kB 1893.60ms - 1897.36ms - faster ✔
0% - 1%
4.53ms - 10.19ms
branch 1.05 MB 1900.72ms - 1904.96ms slower ❌
0% - 1%
4.53ms - 10.19ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 723 kB 799.11ms - 820.29ms - faster ✔
4% - 7%
33.34ms - 57.18ms
branch 936 kB 849.49ms - 860.43ms slower ❌
4% - 7%
33.34ms - 57.18ms		 -

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 518 kB 70.40ms - 76.20ms - faster ✔
8% - 18%
6.52ms - 15.48ms
branch 757 kB 80.89ms - 87.71ms slower ❌
8% - 22%
6.52ms - 15.48ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 766 kB 60.11ms - 64.85ms - faster ✔
10% - 17%
7.36ms - 12.28ms
branch 957 kB 71.65ms - 72.95ms slower ❌
11% - 20%
7.36ms - 12.28ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 766 kB 699.95ms - 712.73ms - unsure 🔍
-2% - +2%
-14.15ms - +11.27ms
branch 957 kB 696.79ms - 718.77ms unsure 🔍
-2% - +2%
-11.27ms - +14.15ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 694 kB 106.27ms - 111.01ms - faster ✔
5% - 10%
5.80ms - 11.68ms
branch 898 kB 115.64ms - 119.12ms slower ❌
5% - 11%
5.80ms - 11.68ms		 -

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 417 kB 25.34ms - 27.06ms - faster ✔
13% - 20%
3.86ms - 6.34ms
branch 638 kB 30.41ms - 32.19ms slower ❌
14% - 25%
3.86ms - 6.34ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 423.85ms - 439.03ms - slower ❌
4% - 9%
16.72ms - 37.00ms
branch 716 kB 397.86ms - 411.30ms faster ✔
4% - 8%
16.72ms - 37.00ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 824 kB 625.85ms - 646.59ms - slower ❌
1% - 4%
4.76ms - 25.96ms
branch 1.01 MB 618.69ms - 623.03ms faster ✔
1% - 4%
4.76ms - 25.96ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 827 kB 46.90ms - 47.42ms - faster ✔
12% - 15%
6.73ms - 8.19ms
branch 1.02 MB 53.93ms - 55.31ms slower ❌
14% - 17%
6.73ms - 8.19ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 643.31ms - 649.25ms - slower ❌
2% - 3%
11.75ms - 19.65ms
branch 1.01 MB 627.97ms - 633.19ms faster ✔
2% - 3%
11.75ms - 19.65ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 612 kB 88.71ms - 95.61ms - faster ✔
5% - 12%
4.56ms - 12.40ms
branch 805 kB 98.79ms - 102.49ms slower ❌
5% - 14%
4.56ms - 12.40ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 570 kB 968.23ms - 990.49ms - faster ✔
5% - 7%
48.85ms - 72.67ms
branch 774 kB 1035.88ms - 1044.36ms slower ❌
5% - 7%
48.85ms - 72.67ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 584 kB 139.40ms - 146.76ms - faster ✔
5% - 12%
7.54ms - 19.14ms
branch 774 kB 151.94ms - 160.90ms slower ❌
5% - 14%
7.54ms - 19.14ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 156.90ms - 164.38ms - faster ✔
4% - 10%
5.91ms - 16.93ms
branch 717 kB 168.01ms - 176.11ms slower ❌
4% - 11%
5.91ms - 16.93ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 74.05ms - 79.11ms - unsure 🔍
-3% - +5%
-1.94ms - +3.54ms
branch 910 kB 74.73ms - 76.83ms unsure 🔍
-5% - +2%
-3.54ms - +1.94ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 584 kB 45.37ms - 47.27ms - faster ✔
11% - 16%
5.80ms - 8.72ms
branch 788 kB 52.47ms - 54.69ms slower ❌
12% - 19%
5.80ms - 8.72ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 123.91ms - 129.49ms - slower ❌
0% - 6%
0.21ms - 7.35ms
branch 911 kB 120.69ms - 125.15ms faster ✔
0% - 6%
0.21ms - 7.35ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 685 kB 85.55ms - 90.01ms - faster ✔
12% - 18%
11.86ms - 19.18ms
branch 886 kB 100.39ms - 106.21ms slower ❌
13% - 22%
11.86ms - 19.18ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 547 kB 98.72ms - 103.52ms - faster ✔
9% - 16%
9.41ms - 18.19ms
branch 761 kB 111.25ms - 118.59ms slower ❌
9% - 18%
9.41ms - 18.19ms		 -

@rubencarvalho
Copy link
Collaborator Author

cc: @TarunAdobe
Do you have more info about these action button failures?

@TarunAdobe
Copy link
Contributor

TarunAdobe commented Nov 1, 2024 •
edited
Loading

cc: @TarunAdobe Do you have more info about these action button failures?

Yess! I dug a bit deeper into it and what I can see is that this issue is stemming from the fact that some css property after getting processed are coming in different order for us than they used to. This is messing up the specificity and causing the VRT failures.

Check this and notice that we have :host([selected] properties before the :host([quiet]) ones and thus the incorrect styles.
On the other hand this is how it looks in main right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubencarvalho @coveralls @TarunAdobe