-
Notifications
You must be signed in to change notification settings - Fork 228
feat(reactive-controllers): Migrate to Colorjs from Tinycolor #4713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Pull Request Test Coverage Report for Build 13498253698Details
💛 - Coveralls |
Tachometer resultsCurrently, no packages are changed by this PR... |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
…nents into color-migration
…nents into color-migration
* feat(reactive-controllers): added color orchestration layer * chore: updated yarn lock * chore(reactive-controllers): minor fix * chore: updated yarn lock * chore(reactive-controllers): added tests and color formats * chore(reactive-controllers): updated rgb limits * chore(color-field): updated color field * chore(color-field): updated tests * chore(reactive-controllers): added some tests * chore(reactive-controllers): added some more tests * chore(color-area, color-slider): migrated to colorjs * chore(color-slider): updated tests * chore(color-area): resolved tests * chore(color-wheel): migrated color wheel to colorjs * chore(color-area): updated stories * chore(reactive-controllers): removed tinycolor completely * chore: fully removed tinycolor * chore: updated golden image hash * chore(color-area): minor fix * chore(reactive-controllers): added a check for invalid color formats * chore(reactive-controllers): minor fix * chore: added docs block for color controller * chore(color-area): added docs * chore(reactive-controllers): added a readme file * chore(reactive-controllers): minor fix in docs * chore: updated image hash * chore: updated image hash * chore: updated versions * chore: updated yarn lock * chore: minor-fix * chore: minor fixes * chore: updated image hash * chore(color-area): updated with change in slider value * chore(color-area): added a test * chore: updated yarn lock * chore: updated golden image hash * chore: updated golden image hash * chore: updated yarnlock * chore: updated yarn lock * chore(color-wheel): updated tests * chore: updated image hash * chore: updated yarn lock * chore: updated image hash * chore: reverted image hash * chore: updated image hash * chore: updated image hash * chore: updated stories * chore: updated image hash * chore: skipping cache restoration --------- Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rúben Carvalho <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]>
* feat(reactive-controllers): added color orchestration layer * chore: updated yarn lock * chore(reactive-controllers): minor fix * chore: updated yarn lock * chore(reactive-controllers): added tests and color formats * chore(reactive-controllers): updated rgb limits * chore(color-field): updated color field * chore(color-field): updated tests * chore(reactive-controllers): added some tests * chore(reactive-controllers): added some more tests * chore(color-area, color-slider): migrated to colorjs * chore(color-slider): updated tests * chore(color-area): resolved tests * chore(color-wheel): migrated color wheel to colorjs * chore(color-area): updated stories * chore(reactive-controllers): removed tinycolor completely * chore: fully removed tinycolor * chore: updated golden image hash * chore(color-area): minor fix * chore(reactive-controllers): added a check for invalid color formats * chore(reactive-controllers): minor fix * chore: added docs block for color controller * chore(color-area): added docs * chore(reactive-controllers): added a readme file * chore(reactive-controllers): minor fix in docs * chore: updated image hash * chore: updated image hash * chore: updated versions * chore: updated yarn lock * chore: minor-fix * chore: minor fixes * chore: updated image hash * chore(color-area): updated with change in slider value * chore(color-area): added a test * chore: updated yarn lock * chore: updated golden image hash * chore: updated golden image hash * chore: updated yarnlock * chore: updated yarn lock * chore(color-wheel): updated tests * chore: updated image hash * chore: updated yarn lock * chore: updated image hash * chore: reverted image hash * chore: updated image hash * chore: updated image hash * chore: updated stories * chore: updated image hash * chore: skipping cache restoration --------- Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rúben Carvalho <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]>
This PR marks the initial steps in our color library migration for Spectrum Web Components. As part of this effort, I have implemented an abstraction layer that includes the following key elements:
Color Types: Defined standardized types to ensure consistent handling of color data across components.
Transformation Functions: Created functions to handle color conversions and transformations, making it easier to work with various color formats.
This abstraction layer is designed to facilitate a smoother migration process and minimize the impact on our consumers. By isolating the color logic, we can easily adapt to future changes in the underlying color library.
Stay tuned for more details—there's much more to come! 🚀
Related issue(s)
#3950 ✅ (Solved)
#3883 ✅ (Solved)
#3655 ✅ (Solved)
#3071 ✅ (Solved)
#3058 ✅ (Solved)
Motivation and context
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.