Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): bump css version to increase slider z-index #4682

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

rubencarvalho
Copy link
Collaborator

@rubencarvalho rubencarvalho commented Aug 21, 2024

Description

Bumps the CSS version for Slider to pick up the latest z-index related changes.

Related issue(s)

Motivation and context

Uses z-index: 0 (instead of z-index: 1) for our Slider component so that the slider no longer "floats" over other elements on the page.

How has this been tested?

  • VRTs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@rubencarvalho rubencarvalho marked this pull request as ready for review August 21, 2024 10:23
@rubencarvalho rubencarvalho requested a review from a team as a code owner August 21, 2024 10:23
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@rubencarvalho
Copy link
Collaborator Author

Slider patch seems unnecessary as of: adobe/spectrum-css#2744

Copy link

Tachometer results

Chrome

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 493 kB 72.11ms - 74.70ms - faster ✔
2% - 6%
1.21ms - 4.44ms
branch 469 kB 75.27ms - 77.19ms slower ❌
2% - 6%
1.21ms - 4.44ms
-
Firefox

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 493 kB 160.76ms - 167.76ms - faster ✔
2% - 7%
2.75ms - 12.57ms
branch 469 kB 168.48ms - 175.36ms slower ❌
2% - 8%
2.75ms - 12.57ms
-

Copy link
Contributor

@TarunAdobe TarunAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rubencarvalho rubencarvalho merged commit 04bba95 into main Aug 26, 2024
53 of 58 checks passed
@rubencarvalho rubencarvalho deleted the ruben/fix-slider-z-index branch August 26, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants