Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update spectrum CSS versions #3916

Merged
merged 2 commits into from
Jan 3, 2024
Merged

chore: update spectrum CSS versions #3916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c439428
chore: update spetrum CSS versions
Westbrook Oct 24, 2023
d0e3eac
ci: update golden images cache
Westbrook Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ executors:
parameters:
current_golden_images_hash:
type: string
default: 399010224101760a8f5247862ef7f3eb900b2382
default: 69904096a0526a3ef8bbf1b2667d9edb4adc821b
wireit_cache_name:
type: string
default: wireit
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@
"command": "yarn workspace @spectrum-web-components/icons-ui build",
"files": [
"packages/icons-ui/bin/build.js",
"packages/icons-ui/packages.json",
"node_modules/@spectrum-css/ui-icons/dist/medium/**.svg"
],
"output": [
Expand Down
2 changes: 1 addition & 1 deletion packages/accordion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/accordion": "^4.0.17"
"@spectrum-css/accordion": "^4.0.27"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/action-bar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"@spectrum-web-components/popover": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/actionbar": "^7.0.1"
"@spectrum-css/actionbar": "^7.0.11"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/action-button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/actionbutton": "^5.0.7"
"@spectrum-css/actionbutton": "^5.0.17"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/action-group/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"@spectrum-web-components/reactive-controllers": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/actiongroup": "^4.0.7"
"@spectrum-css/actiongroup": "^4.1.9"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
6 changes: 3 additions & 3 deletions packages/action-group/stories/action-group-tooltip.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ class ActionGroupTooltips extends SpectrumElement {
></rect>
</svg>
</sp-icon>
<sp-tooltip self-managed placement="bottom" offset="0">
<sp-tooltip self-managed placement="bottom">
Left align
</sp-tooltip>
</sp-action-button>
Expand Down Expand Up @@ -341,7 +341,7 @@ class ActionGroupTooltips extends SpectrumElement {
></rect>
</svg>
</sp-icon>
<sp-tooltip self-managed placement="bottom" offset="0">
<sp-tooltip self-managed placement="bottom">
Center align
</sp-tooltip>
</sp-action-button>
Expand Down Expand Up @@ -398,7 +398,7 @@ class ActionGroupTooltips extends SpectrumElement {
></rect>
</svg>
</sp-icon>
<sp-tooltip self-managed placement="bottom" offset="0">
<sp-tooltip self-managed placement="bottom">
Right align
</sp-tooltip>
</sp-action-button>
Expand Down
2 changes: 1 addition & 1 deletion packages/action-menu/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/actionmenu": "^5.0.0"
"@spectrum-css/actionmenu": "^5.0.10"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/alert-dialog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/alertdialog": "^1.0.6"
"@spectrum-css/alertdialog": "^1.0.16"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
4 changes: 2 additions & 2 deletions packages/alert-dialog/src/spectrum-alert-dialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ governing permissions and limitations under the License.
display: flex;
inline-size: -moz-fit-content;
inline-size: fit-content;
max-block-size: inherit;
max-inline-size: var(
--mod-alert-dialog-max-width,
var(--spectrum-alert-dialog-max-width)
);
max-height: inherit;
min-inline-size: var(
--mod-alert-dialog-min-width,
var(--spectrum-alert-dialog-min-width)
Expand All @@ -90,7 +90,7 @@ governing permissions and limitations under the License.
--mod-alert-dialog-icon-size,
var(--spectrum-alert-dialog-icon-size)
);
margin-left: var(
margin-inline-start: var(
--mod-alert-dialog-title-to-icon,
var(--spectrum-alert-dialog-title-to-icon)
);
Expand Down
2 changes: 1 addition & 1 deletion packages/asset/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@spectrum-web-components/base": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/asset": "^3.0.48"
"@spectrum-css/asset": "^3.0.51"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/avatar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/avatar": "^6.0.52"
"@spectrum-css/avatar": "^6.0.62"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/avatar/src/spectrum-avatar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ governing permissions and limitations under the License.
}
@media (forced-colors: active) {
:host {
--highcontrast-avatar-color-opacity-disabled: 1;
--highcontrast-avatar-focus-indicator-color: CanvasText;
}
}
Expand Down Expand Up @@ -220,7 +219,7 @@ governing permissions and limitations under the License.
position: absolute;
}
.link {
outline: none;
outline: solid #0000;
}
.image {
block-size: var(--mod-avatar-block-size, var(--spectrum-avatar-block-size));
Expand Down
2 changes: 1 addition & 1 deletion packages/badge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/badge": "^3.1.8"
"@spectrum-css/badge": "^3.1.18"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
1 change: 0 additions & 1 deletion packages/badge/src/spectrum-badge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ governing permissions and limitations under the License.
:host {
-webkit-font-smoothing: subpixel-antialiased;
-moz-osx-font-smoothing: auto;
font-smoothing: subpixel-antialiased;
background: var(
--mod-badge-background-color-default,
var(--spectrum-badge-background-color-default)
Expand Down
2 changes: 1 addition & 1 deletion packages/button-group/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@spectrum-web-components/button": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/buttongroup": "^6.1.6"
"@spectrum-css/buttongroup": "^6.1.16"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/button": "^11.0.8"
"@spectrum-css/button": "^11.0.18"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
4 changes: 3 additions & 1 deletion packages/button/src/spectrum-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ governing permissions and limitations under the License.
}
:host:after {
display: block;
inset-block: 0;
inset-inline: 0;
margin: calc(
var(--mod-focus-indicator-gap, var(--spectrum-focus-indicator-gap)) * -1
);
Expand Down Expand Up @@ -106,11 +108,11 @@ governing permissions and limitations under the License.
--spectrum-button-border-radius: var(--spectrum-corner-radius-100);
--spectrum-button-border-width: var(--spectrum-border-width-200);
--spectrum-button-line-height: 1.2;
--spectrum-button-focus-ring-gap: var(--spectrum-focus-indicator-gap);
--spectrum-button-focus-ring-border-radius: calc(
var(--spectrum-button-border-radius) +
var(--spectrum-button-focus-ring-gap)
);
--spectrum-button-focus-ring-gap: var(--spectrum-focus-indicator-gap);
--spectrum-button-focus-ring-thickness: var(
--spectrum-focus-indicator-thickness
);
Expand Down
2 changes: 1 addition & 1 deletion packages/card/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@spectrum-web-components/styles": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/card": "^6.2.1"
"@spectrum-css/card": "^6.2.2"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/checkbox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/checkbox": "^8.0.3"
"@spectrum-css/checkbox": "^8.0.4"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/clear-button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@spectrum-web-components/base": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/clearbutton": "^5.0.5"
"@spectrum-css/clearbutton": "^5.0.15"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/close-button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@spectrum-web-components/base": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/closebutton": "^4.0.7"
"@spectrum-css/closebutton": "^4.0.17"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
13 changes: 10 additions & 3 deletions packages/close-button/src/spectrum-close-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ governing permissions and limitations under the License.
:host {
align-items: center;
align-self: var(--mod-closebutton-align-self);
block-size: var(
--mod-closebutton-height,
var(--spectrum-closebutton-height)
);
border-color: #0000;
border-radius: var(
--mod-closebutton-border-radius,
Expand All @@ -232,7 +236,10 @@ governing permissions and limitations under the License.
color: inherit;
display: inline-flex;
flex-direction: row;
height: var(--mod-closebutton-height, var(--spectrum-closebutton-height));
inline-size: var(
--mod-closebutton-width,
var(--spectrum-closebutton-width)
);
justify-content: center;
margin-block-start: var(--mod-closebutton-margin-top);
margin-inline: var(--mod-closebutton-margin-inline);
Expand All @@ -244,7 +251,6 @@ governing permissions and limitations under the License.
var(--spectrum-closebutton-animation-duration)
)
ease-in-out;
width: var(--mod-closebutton-width, var(--spectrum-closebutton-width));
}
:host:after {
border-radius: calc(
Expand All @@ -255,7 +261,8 @@ governing permissions and limitations under the License.
)
);
content: '';
inset: 0;
inset-block: 0;
inset-inline: 0;
margin: calc(
var(
--mod-closebutton-focus-indicator-gap,
Expand Down
2 changes: 1 addition & 1 deletion packages/color-area/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/colorarea": "^4.0.41"
"@spectrum-css/colorarea": "^4.0.51"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/color-handle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@spectrum-web-components/opacity-checkerboard": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/colorhandle": "^7.0.7"
"@spectrum-css/colorhandle": "^7.0.17"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/color-loupe/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@spectrum-web-components/opacity-checkerboard": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/colorloupe": "^4.1.18"
"@spectrum-css/colorloupe": "^4.1.28"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/color-slider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/colorslider": "^5.0.4"
"@spectrum-css/colorslider": "^5.0.14"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/color-wheel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"@spectrum-web-components/shared": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/colorwheel": "^3.0.41"
"@spectrum-css/colorwheel": "^3.0.51"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/dialog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"@spectrum-web-components/underlay": "^0.40.2"
},
"devDependencies": {
"@spectrum-css/dialog": "^6.0.68"
"@spectrum-css/dialog": "^9.0.5"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
12 changes: 12 additions & 0 deletions packages/dialog/src/dialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ governing permissions and limitations under the License.

@import url('./spectrum-dialog.css');

:host {
--swc-alert-dialog-error-icon-color: var(--spectrum-negative-visual-color);
}

.content {
overflow: hidden;
}
Expand All @@ -23,6 +27,14 @@ governing permissions and limitations under the License.
);
}

.type-icon {
grid-area: typeIcon;
color: var(
--mod-alert-dialog-error-icon-color,
var(--swc-alert-dialog-error-icon-color)
);
}

.content[tabindex] {
overflow: auto;
}
Expand Down
Loading
Loading