fix(tooltip): update default offset to match Spectrum defs #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachometer resultsChrometooltip permalink
Firefoxtooltip permalink
|
Westbrook
reviewed
Sep 8, 2023
| @@ -126,7 +131,7 @@ export class Tooltip extends SpectrumElement { | |||
| public selfManaged = false; | |||
|
|
|||
| @property({ type: Number }) | |||
| public offset = 0; | |||
| public offset = this.isMobile.matches ? 5 : 4; | |||
There was a problem hiding this comment.
The Spectrum specs never mean "mobile" and "desktop" in this way. They mean it relative to the scale the UI is delivered in. I've reached out to the team about tokens for this before we do anything custom here. If we need to do so, we likely want this in https://github.com/adobe/spectrum-web-components/blob/main/tools/styles/scale-medium.css and https://github.com/adobe/spectrum-web-components/blob/main/tools/styles/scale-large.css
There was a problem hiding this comment.
OK, I wasn't certain if this was referring to the scale or Mobile in general.
And yes it would make sense to check, if this can be solved by a token or spectrum-var.
Will close this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the default tooltip offset regarding to latest Spectrum defs
Description
Tooltip offset is aligned to latest Spectrum defs, see: https://spectrum.adobe.com/page/tooltip/#Offset
Related issue(s)
#3631
Motivation and context
This change aligns tooltip offset with current application and sync with latest Spectrum definitions
How has this been tested?
manual tested
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.